[v2] cpu_map: Add EPYC-Rome model

[PATCH v2 0/4] cpu_map: Add EPYC-Rome model

Posted by Markus Schade 5 years, 4 months ago

this patch series adds testdata from an AMD EPYC 7502 system,
defines and enables the qemu EPYC-Rome model and changes
the existing Ryzen 9 host definition to the new model

Markus Schade (4):
  Add testdata for AMD EPYC 7502
  cpu_map: Defined and enable EPYC-Rome model
  Update generated testdata for EPYC 7502 after adding EPYC-Rome model
  Update cputestdata for Ryzen 9 to EPYC-Rome model

 src/cpu_map/index.xml                         |    1 +
 src/cpu_map/meson.build                       |    1 +
 src/cpu_map/x86_EPYC-Rome.xml                 |   81 +
 tests/cputest.c                               |    3 +-
 ...86_64-cpuid-EPYC-7502-32-Core-disabled.xml |    9 +
 ...x86_64-cpuid-EPYC-7502-32-Core-enabled.xml |   11 +
 .../x86_64-cpuid-EPYC-7502-32-Core-guest.xml  |   35 +
 .../x86_64-cpuid-EPYC-7502-32-Core-host.xml   |   36 +
 .../x86_64-cpuid-EPYC-7502-32-Core-json.xml   |   24 +
 .../x86_64-cpuid-EPYC-7502-32-Core.json       | 1866 +++++++++++++++++
 .../x86_64-cpuid-EPYC-7502-32-Core.sig        |    4 +
 .../x86_64-cpuid-EPYC-7502-32-Core.xml        |   66 +
 ...86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml |    9 +-
 13 files changed, 2137 insertions(+), 9 deletions(-)
 create mode 100644 src/cpu_map/x86_EPYC-Rome.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled=
.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-enabled.=
xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.json
 create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.sig
 create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.xml

--=20
2.26.2

Re: [PATCH v2 0/4] cpu_map: Add EPYC-Rome model

Posted by Markus Schade 5 years, 4 months ago

Am 06.10.20 um 16:50 schrieb Jiri Denemark:
> But, since I don't really like going through the CPU model definition
> again (even though it would be just a diff), I can do these trivial
> changes just before pushing. Just let me know if you're OK with this and
> reply to my question in patch 2/4.
> 
> And I apologize for incorrectly saying Ryzen 9 3900X should be EPYC
> (it's actually EPYC-Rome), which influenced my suggestion to not update
> Ryzen-9-3900X-12-Core.json with new models supported by QEMU. But don't
> worry, I'll do this myself as a follow-up patch since it is my fault.

Feel free to make any changes, you think are still necessary. If I
can/should do a v3, please let me know.

Best regards,
Markus

Re: [PATCH v2 0/4] cpu_map: Add EPYC-Rome model

Posted by Jiri Denemark 5 years, 4 months ago

On Wed, Oct 07, 2020 at 15:56:31 +0200, Markus Schade wrote:
> Am 06.10.20 um 16:50 schrieb Jiri Denemark:
> > But, since I don't really like going through the CPU model definition
> > again (even though it would be just a diff), I can do these trivial
> > changes just before pushing. Just let me know if you're OK with this and
> > reply to my question in patch 2/4.
> > 
> > And I apologize for incorrectly saying Ryzen 9 3900X should be EPYC
> > (it's actually EPYC-Rome), which influenced my suggestion to not update
> > Ryzen-9-3900X-12-Core.json with new models supported by QEMU. But don't
> > worry, I'll do this myself as a follow-up patch since it is my fault.
> 
> Feel free to make any changes, you think are still necessary. If I
> can/should do a v3, please let me know.

With the suggested changes

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>

I squashed the patches in one, added the three missing features and
pushed the result.

Thanks.

Jirka

Re: [PATCH v2 0/4] cpu_map: Add EPYC-Rome model

Posted by Jiri Denemark 5 years, 4 months ago

On Thu, Oct 01, 2020 at 12:22:00 +0200, Markus Schade wrote:
> this patch series adds testdata from an AMD EPYC 7502 system,
> defines and enables the qemu EPYC-Rome model and changes
> the existing Ryzen 9 host definition to the new model
> 
> Markus Schade (4):
>   Add testdata for AMD EPYC 7502
>   cpu_map: Defined and enable EPYC-Rome model

The following two patches and the diff created by
"VIR_TEST_REGENERATE_OUTPUT=1 tests/domaincapstest" should be squashed
in the patch adding the new model to make sure "meson test" passes after
each patch.

>   Update generated testdata for EPYC 7502 after adding EPYC-Rome model
>   Update cputestdata for Ryzen 9 to EPYC-Rome model

But, since I don't really like going through the CPU model definition
again (even though it would be just a diff), I can do these trivial
changes just before pushing. Just let me know if you're OK with this and
reply to my question in patch 2/4.

And I apologize for incorrectly saying Ryzen 9 3900X should be EPYC
(it's actually EPYC-Rome), which influenced my suggestion to not update
Ryzen-9-3900X-12-Core.json with new models supported by QEMU. But don't
worry, I'll do this myself as a follow-up patch since it is my fault.

Jirka