[libvirt PATCH] meson: drop HTML4 variants of rst2html

Daniel P. Berrangé posted 1 patch 3 years, 6 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200925102421.2209182-1-berrange@redhat.com
meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[libvirt PATCH] meson: drop HTML4 variants of rst2html
Posted by Daniel P. Berrangé 3 years, 6 months ago
We stopped supportin Ubuntu 16.04 earlier in the year, so there is no
reason to keep the HTML4 variants of rst2html around.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 meson.build | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meson.build b/meson.build
index bc52079809..2e57a435df 100644
--- a/meson.build
+++ b/meson.build
@@ -898,8 +898,7 @@ required_programs = [
 
 required_programs_groups = [
   {'name':'rpcgen', 'prog':['rpcgen', 'portable-rpcgen']},
-  # Drop the rst2html (aka HTML4) variants once we stop supporting Ubuntu 16.04 (Xenial)
-  {'name':'rst2html', 'prog':['rst2html5', 'rst2html5.py', 'rst2html5-3', 'rst2html', 'rst2html.py', 'rst2html-3']},
+  {'name':'rst2html', 'prog':['rst2html5', 'rst2html5.py', 'rst2html5-3']},
   {'name':'rst2man', 'prog':['rst2man', 'rst2man.py', 'rst2man-3']},
 ]
 
-- 
2.26.2

Re: [libvirt PATCH] meson: drop HTML4 variants of rst2html
Posted by Ján Tomko 3 years, 6 months ago
On a Friday in 2020, Daniel P. Berrangé wrote:
>We stopped supportin Ubuntu 16.04 earlier in the year, so there is no

*supporting

>reason to keep the HTML4 variants of rst2html around.
>

If you want to include the commit that dropped it, I had it looked up
in one terminal already:

commit 57e9f3a7e02988432c8c6790cb058b2b5372821b
     gitlab: update list of distros to use latest versions


>Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>---
> meson.build | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
Re: [libvirt PATCH] meson: drop HTML4 variants of rst2html
Posted by Jiri Denemark 3 years, 6 months ago
On Fri, Sep 25, 2020 at 11:24:21 +0100, Daniel P. Berrangé wrote:
> We stopped supportin Ubuntu 16.04 earlier in the year, so there is no
> reason to keep the HTML4 variants of rst2html around.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  meson.build | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index bc52079809..2e57a435df 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -898,8 +898,7 @@ required_programs = [
>  
>  required_programs_groups = [
>    {'name':'rpcgen', 'prog':['rpcgen', 'portable-rpcgen']},
> -  # Drop the rst2html (aka HTML4) variants once we stop supporting Ubuntu 16.04 (Xenial)
> -  {'name':'rst2html', 'prog':['rst2html5', 'rst2html5.py', 'rst2html5-3', 'rst2html', 'rst2html.py', 'rst2html-3']},
> +  {'name':'rst2html', 'prog':['rst2html5', 'rst2html5.py', 'rst2html5-3']},
>    {'name':'rst2man', 'prog':['rst2man', 'rst2man.py', 'rst2man-3']},
>  ]
>  

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>