improve pSeries NVDIMM support

[PATCH v2 0/3] improve pSeries NVDIMM support

Posted by Daniel Henrique Barboza 5 years, 4 months ago

Hi,

This is a follow up of [1] after Andrea pushed the revert
patch as standalone.

Changes from v1:
- patch 2 (former 3): moved the auto-align code from
  virDomainMemoryDefParseXML() to virDomainMemoryDefPostParse()
- patch 3 (former 4): updated NEWS.rst based on Andrea's
changes already upstream


[1] https://www.redhat.com/archives/libvir-list/2020-September/msg00864.html

Daniel Henrique Barboza (3):
  conf, qemu: move qemuDomainNVDimmAlignSizePseries to domain_conf.c
  domain_conf.c: auto-align pSeries NVDIMM in
    virDomainMemoryDefPostParse()
  NEWS.rst: update NVDIMM changes entry

 NEWS.rst                                      |  3 +-
 src/conf/domain_conf.c                        | 59 ++++++++++++++++++-
 src/conf/domain_conf.h                        |  3 +
 src/libvirt_private.syms                      |  1 +
 src/qemu/qemu_domain.c                        | 42 +------------
 .../memory-hotplug-nvdimm-ppc64.xml           |  2 +-
 6 files changed, 67 insertions(+), 43 deletions(-)

-- 
2.26.2

Re: [PATCH v2 0/3] improve pSeries NVDIMM support

Posted by Andrea Bolognani 5 years, 4 months ago

On Tue, 2020-09-22 at 09:29 -0300, Daniel Henrique Barboza wrote:
> Hi,
> 
> This is a follow up of [1] after Andrea pushed the revert
> patch as standalone.
> 
> Changes from v1:
> - patch 2 (former 3): moved the auto-align code from
>   virDomainMemoryDefParseXML() to virDomainMemoryDefPostParse()
> - patch 3 (former 4): updated NEWS.rst based on Andrea's
> changes already upstream
> 
> 
> [1] https://www.redhat.com/archives/libvir-list/2020-September/msg00864.html
> 
> Daniel Henrique Barboza (3):
>   conf, qemu: move qemuDomainNVDimmAlignSizePseries to domain_conf.c
>   domain_conf.c: auto-align pSeries NVDIMM in
>     virDomainMemoryDefPostParse()
>   NEWS.rst: update NVDIMM changes entry

Looks good!

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

Can you please confirm your GitLab account is 'danielhb'? I would
like to add you to the libvirt organization so that you can start
pushing your own patches instead of relying on someone else doing
that for you.

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH v2 0/3] improve pSeries NVDIMM support

Posted by Daniel Henrique Barboza 5 years, 4 months ago


On 9/22/20 11:56 AM, Andrea Bolognani wrote:
> On Tue, 2020-09-22 at 09:29 -0300, Daniel Henrique Barboza wrote:
>> Hi,
>>
>> This is a follow up of [1] after Andrea pushed the revert
>> patch as standalone.
>>
>> Changes from v1:
>> - patch 2 (former 3): moved the auto-align code from
>>    virDomainMemoryDefParseXML() to virDomainMemoryDefPostParse()
>> - patch 3 (former 4): updated NEWS.rst based on Andrea's
>> changes already upstream
>>
>>
>> [1] https://www.redhat.com/archives/libvir-list/2020-September/msg00864.html
>>
>> Daniel Henrique Barboza (3):
>>    conf, qemu: move qemuDomainNVDimmAlignSizePseries to domain_conf.c
>>    domain_conf.c: auto-align pSeries NVDIMM in
>>      virDomainMemoryDefPostParse()
>>    NEWS.rst: update NVDIMM changes entry
> 
> Looks good!
> 
>    Reviewed-by: Andrea Bolognani <abologna@redhat.com>
> 
> Can you please confirm your GitLab account is 'danielhb'? I would
> like to add you to the libvirt organization so that you can start
> pushing your own patches instead of relying on someone else doing
> that for you.


Yes, 'danielhb' is my Gitlab username as well:


https://gitlab.com/danielhb


DHB

>

Re: [PATCH v2 0/3] improve pSeries NVDIMM support

Posted by Andrea Bolognani 5 years, 4 months ago

On Tue, 2020-09-22 at 14:52 -0300, Daniel Henrique Barboza wrote:
> On 9/22/20 11:56 AM, Andrea Bolognani wrote:
> > On Tue, 2020-09-22 at 09:29 -0300, Daniel Henrique Barboza wrote:
> > > Daniel Henrique Barboza (3):
> > >    conf, qemu: move qemuDomainNVDimmAlignSizePseries to domain_conf.c
> > >    domain_conf.c: auto-align pSeries NVDIMM in
> > >      virDomainMemoryDefPostParse()
> > >    NEWS.rst: update NVDIMM changes entry
> > 
> > Looks good!
> > 
> >    Reviewed-by: Andrea Bolognani <abologna@redhat.com>
> > 
> > Can you please confirm your GitLab account is 'danielhb'? I would
> > like to add you to the libvirt organization so that you can start
> > pushing your own patches instead of relying on someone else doing
> > that for you.
> 
> Yes, 'danielhb' is my Gitlab username as well:
> 
> https://gitlab.com/danielhb

Great! I've added you to the group, you should be able to push
patches to master now. Please make sure to pick up the R-bs before
doing so.

And, you know, always keep uncle Ben's wisdom in mind ;)

-- 
Andrea Bolognani / Red Hat / Virtualization