util: fix non-null pointer parameter annotations

[PATCH] util: fix non-null pointer parameter annotations

Daniel P. Berrangé posted 1 patch 3 years, 6 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200921085907.1945575-1-berrange@redhat.com

src/util/virqemu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] util: fix non-null pointer parameter annotations

Posted by Daniel P. Berrangé 3 years, 6 months ago

An extra parameter was added to virQEMUBuildQemuImgKeySecretOpts in

  commit ecfc4094d832a23fb56e1825d799c93488c168d7
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Tue Sep 15 16:30:37 2020 +0100

    storage: add support for qcow2 LUKS encryption

but the non-null pointer annotations were not adjusted to take account.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/util/virqemu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virqemu.h b/src/util/virqemu.h
index be14c04d51..2b33968158 100644
--- a/src/util/virqemu.h
+++ b/src/util/virqemu.h
@@ -63,4 +63,4 @@ void virQEMUBuildQemuImgKeySecretOpts(virBufferPtr buf,
                                       int format,
                                       virStorageEncryptionInfoDefPtr enc,
                                       const char *alias)
-    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3);
+    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4);
-- 
2.26.2

Re: [PATCH] util: fix non-null pointer parameter annotations

Posted by Andrea Bolognani 3 years, 6 months ago

On Mon, 2020-09-21 at 09:59 +0100, Daniel P. Berrangé wrote:
> An extra parameter was added to virQEMUBuildQemuImgKeySecretOpts in
> 
>   commit ecfc4094d832a23fb56e1825d799c93488c168d7
>   Author: Daniel P. Berrangé <berrange@redhat.com>
>   Date:   Tue Sep 15 16:30:37 2020 +0100
> 
>     storage: add support for qcow2 LUKS encryption
> 
> but the non-null pointer annotations were not adjusted to take account.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/util/virqemu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization