[PATCH v3 1/6] qemu: Block blockjobs when transient disk option is enabled

Masayoshi Mizuma posted 6 patches 5 years, 4 months ago
[PATCH v3 1/6] qemu: Block blockjobs when transient disk option is enabled
Posted by Masayoshi Mizuma 5 years, 4 months ago
From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>

Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
---
 src/qemu/qemu_domain.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 785cee6f18..1ce0f70971 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -10794,6 +10794,13 @@ qemuDomainDiskBlockJobIsSupported(virDomainObjPtr vm,
         return false;
     }
 
+    if (disk->transient) {
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
+                       _("block jobs are not supported on transient disk '%s'"),
+                       disk->dst);
+        return false;
+    }
+
     return true;
 }
 
-- 
2.27.0

Re: [PATCH v3 1/6] qemu: Block blockjobs when transient disk option is enabled
Posted by Peter Krempa 5 years, 4 months ago
On Thu, Sep 17, 2020 at 09:30:40 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> 
> Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> ---
>  src/qemu/qemu_domain.c | 7 +++++++
>  1 file changed, 7 insertions(+)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

Re: [PATCH v3 1/6] qemu: Block blockjobs when transient disk option is enabled
Posted by Peter Krempa 5 years, 4 months ago
On Fri, Sep 18, 2020 at 14:53:53 +0200, Peter Krempa wrote:
> On Thu, Sep 17, 2020 at 09:30:40 -0400, Masayoshi Mizuma wrote:
> > From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> > 
> > Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> > ---
> >  src/qemu/qemu_domain.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> 
> Reviewed-by: Peter Krempa <pkrempa@redhat.com>

Actually, I'd prefer some explanation in the commit message. No need to
re-send for now as I'll probably be fixing some things in other patches
as well.

Re: [PATCH v3 1/6] qemu: Block blockjobs when transient disk option is enabled
Posted by Masayoshi Mizuma 5 years, 4 months ago
On Fri, Sep 18, 2020 at 02:57:08PM +0200, Peter Krempa wrote:
> On Fri, Sep 18, 2020 at 14:53:53 +0200, Peter Krempa wrote:
> > On Thu, Sep 17, 2020 at 09:30:40 -0400, Masayoshi Mizuma wrote:
> > > From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> > > 
> > > Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> > > ---
> > >  src/qemu/qemu_domain.c | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > 
> > Reviewed-by: Peter Krempa <pkrempa@redhat.com>
> 
> Actually, I'd prefer some explanation in the commit message. No need to
> re-send for now as I'll probably be fixing some things in other patches
> as well.

Got it, thank you so much for your help!

- Masa