rpm: Remove pointless explicit dependency on 'readline'

[PATCH] rpm: Remove pointless explicit dependency on 'readline'

Neal Gompa posted 1 patch 3 years, 7 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200907185938.31037-1-ngompa13@gmail.com

libvirt.spec.in | 2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[PATCH] rpm: Remove pointless explicit dependency on 'readline'

Posted by Neal Gompa 3 years, 7 months ago

The 'readline' package only contains the library, which rpm is
already generating the (stricter) correct dependency for.

Signed-off-by: Neal Gompa <ngompa13@gmail.com>
---
 libvirt.spec.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index d124a7ce45..379cf0d9be 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -891,7 +891,6 @@ capabilities of VirtualBox
 %package client
 Summary: Client side utilities of the libvirt library
 Requires: %{name}-libs = %{version}-%{release}
-Requires: readline
 # Needed by /usr/libexec/libvirt-guests.sh script.
 Requires: gettext
 # Needed by virt-pki-validate script.
@@ -918,7 +917,6 @@ Shared libraries for accessing the libvirt daemon.
 %package admin
 Summary: Set of tools to control libvirt daemon
 Requires: %{name}-libs = %{version}-%{release}
-Requires: readline
 %if %{with_bash_completion}
 Requires: %{name}-bash-completion = %{version}-%{release}
 %endif
-- 
2.26.2

Re: [PATCH] rpm: Remove pointless explicit dependency on 'readline'

Posted by Michal Privoznik 3 years, 7 months ago

On 9/7/20 8:59 PM, Neal Gompa wrote:
> The 'readline' package only contains the library, which rpm is
> already generating the (stricter) correct dependency for.
> 
> Signed-off-by: Neal Gompa <ngompa13@gmail.com>
> ---
>   libvirt.spec.in | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal