Fix IPv6 network startup after removal of "dummy" tap device

[libvirt PATCH 0/2] Fix IPv6 network startup after removal of "dummy" tap device

Laine Stump posted 2 patches 3 years, 7 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200904180115.74839-1-laine@redhat.com

src/libvirt_private.syms    |   1 -
src/network/bridge_driver.c |  32 ----------
src/util/virnetdevip.c      | 119 ------------------------------------
src/util/virnetdevip.h      |   2 -
4 files changed, 154 deletions(-)

Expand all Fold all

[libvirt PATCH 0/2] Fix IPv6 network startup after removal of "dummy" tap device

Posted by Laine Stump 3 years, 7 months ago

After the patch that removed the dummy tap device was added (commit
ee6c936fbb), IPv6 networks would no longer start due to a "failure to
complete DAD". Since this wait was only necessary because of the
existence of the dummy tap device (see detailed git log spelunking in
Patch 1 comment), we can just remove the wait.

Laine Stump (2):
  network: don't wait for IPv6 DAD completion when starting a network
  util: remove unused virNetDevIPWaitDadFinish()

 src/libvirt_private.syms    |   1 -
 src/network/bridge_driver.c |  32 ----------
 src/util/virnetdevip.c      | 119 ------------------------------------
 src/util/virnetdevip.h      |   2 -
 4 files changed, 154 deletions(-)

-- 
2.26.2

Re: [libvirt PATCH 0/2] Fix IPv6 network startup after removal of "dummy" tap device

Posted by Ján Tomko 3 years, 7 months ago

On a Friday in 2020, Laine Stump wrote:
>After the patch that removed the dummy tap device was added (commit
>ee6c936fbb), IPv6 networks would no longer start due to a "failure to
>complete DAD". Since this wait was only necessary because of the
>existence of the dummy tap device (see detailed git log spelunking in
>Patch 1 comment), we can just remove the wait.
>
>Laine Stump (2):
>  network: don't wait for IPv6 DAD completion when starting a network
>  util: remove unused virNetDevIPWaitDadFinish()
>
> src/libvirt_private.syms    |   1 -
> src/network/bridge_driver.c |  32 ----------
> src/util/virnetdevip.c      | 119 ------------------------------------
> src/util/virnetdevip.h      |   2 -

> 4 files changed, 154 deletions(-)
>

Beautiful.

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano