Support TLS for NBD connections for pull mode backup.
Signed-off-by: Yanqiu Zhang <yanqzhan@redhat.com>
---
NEWS.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e4b71e6563..d0b16e28fc 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -161,6 +161,12 @@ v6.6.0 (2020-08-02)
The secret key used for disks can now be encrypted similarly to TLS keys
used for migration, chardev and others.
+ * qemu: Support TLS for NBD connections for pull mode backup
+
+ Use the configured TLS env to setup encryption of the TLS transport. Add 'tls'
+ attribute for 'server' element to enable tls. Possible values are ``yes``
+ or ``no``.
+
* qemu: ``VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD`` can now be registered for ``<mirror>``
The event can now be used also for block copy destinations by using the
--
2.25.4
The summary of commit msg could be more direct: news: qemu: Support TLS for NBD connections for pull mode backup And then you can skip the body of commit msg. On Thu, Sep 3, 2020 at 10:59 AM Yanqiu Zhang <yanqzhan@redhat.com> wrote: > Support TLS for NBD connections for pull mode backup. > > Signed-off-by: Yanqiu Zhang <yanqzhan@redhat.com> > --- > NEWS.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index e4b71e6563..d0b16e28fc 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -161,6 +161,12 @@ v6.6.0 (2020-08-02) > The secret key used for disks can now be encrypted similarly to TLS > keys > used for migration, chardev and others. > > + * qemu: Support TLS for NBD connections for pull mode backup > + > + Use the configured TLS env to setup encryption of the TLS transport. > Add 'tls' > + attribute for 'server' element to enable tls. Possible values are > ``yes`` > + or ``no``. > + > * qemu: ``VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD`` can now be registered > for ``<mirror>`` > > The event can now be used also for block copy destinations by using > the > -- > 2.25.4 > > -- Best regards, ----------------------------------- Han Han Senior Quality Engineer Redhat. Email: hhan@redhat.com Phone: +861065339333
On Thu, 2020-09-03 at 11:16 +0800, Han Han wrote: > The summary of commit msg could be more direct: > news: qemu: Support TLS for NBD connections for pull mode backup > > And then you can skip the body of commit msg. This is a good suggestion, which I've applied before adding my Reviewed-by: Andrea Bolognani <abologna@redhat.com> and pushing the patch. As an additional note, in the future please refrain from CC'ing individual developers when you post patches: all libvirt maintainers are subscribed to libvir-list and read it regularly. -- Andrea Bolognani / Red Hat / Virtualization
Ok. Thank you both! On Thu, Sep 3, 2020 at 6:10 PM Andrea Bolognani <abologna@redhat.com> wrote: > On Thu, 2020-09-03 at 11:16 +0800, Han Han wrote: > > The summary of commit msg could be more direct: > > news: qemu: Support TLS for NBD connections for pull mode backup > > > > And then you can skip the body of commit msg. > > This is a good suggestion, which I've applied before adding my > > Reviewed-by: Andrea Bolognani <abologna@redhat.com> > > and pushing the patch. > > As an additional note, in the future please refrain from CC'ing > individual developers when you post patches: all libvirt maintainers > are subscribed to libvir-list and read it regularly. > > -- > Andrea Bolognani / Red Hat / Virtualization > > -- Best Regards, Yanqiu Zhang
On Thu, Sep 03, 2020 at 02:56:48 +0000, Yanqiu Zhang wrote: > Support TLS for NBD connections for pull mode backup. > > Signed-off-by: Yanqiu Zhang <yanqzhan@redhat.com> > --- > NEWS.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index e4b71e6563..d0b16e28fc 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -161,6 +161,12 @@ v6.6.0 (2020-08-02) > The secret key used for disks can now be encrypted similarly to TLS keys > used for migration, chardev and others. > > + * qemu: Support TLS for NBD connections for pull mode backup > + > + Use the configured TLS env to setup encryption of the TLS transport. Add 'tls' > + attribute for 'server' element to enable tls. Possible values are ``yes`` > + or ``no``. Incremental backup is not enabled yet, so there's no real point in documenting patches implementing parts of it. NACK
On Mon, 2020-09-07 at 14:42 +0200, Peter Krempa wrote: > On Thu, Sep 03, 2020 at 02:56:48 +0000, Yanqiu Zhang wrote: > > + * qemu: Support TLS for NBD connections for pull mode backup > > + > > + Use the configured TLS env to setup encryption of the TLS transport. Add 'tls' > > + attribute for 'server' element to enable tls. Possible values are ``yes`` > > + or ``no``. > > Incremental backup is not enabled yet, so there's no real point in > documenting patches implementing parts of it. > > NACK Makes sense... Unfortunately the patch has been pushed already. Do you want me to revert it? Do you want to do that yourself? -- Andrea Bolognani / Red Hat / Virtualization
On Mon, Sep 07, 2020 at 15:41:34 +0200, Andrea Bolognani wrote: > On Mon, 2020-09-07 at 14:42 +0200, Peter Krempa wrote: > > On Thu, Sep 03, 2020 at 02:56:48 +0000, Yanqiu Zhang wrote: > > > + * qemu: Support TLS for NBD connections for pull mode backup > > > + > > > + Use the configured TLS env to setup encryption of the TLS transport. Add 'tls' > > > + attribute for 'server' element to enable tls. Possible values are ``yes`` > > > + or ``no``. > > > > Incremental backup is not enabled yet, so there's no real point in > > documenting patches implementing parts of it. > > > > NACK > > Makes sense... Unfortunately the patch has been pushed already. Do > you want me to revert it? Do you want to do that yourself? Sure, here's the patch: https://www.redhat.com/archives/libvir-list/2020-September/msg00349.html I've specifically also mentioned before that I don't see a point in documenting stuff for incremental backup: https://www.redhat.com/archives/libvir-list/2020-July/msg00267.html
On Mon, 2020-09-07 at 16:48 +0200, Peter Krempa wrote: > On Mon, Sep 07, 2020 at 15:41:34 +0200, Andrea Bolognani wrote: > > On Mon, 2020-09-07 at 14:42 +0200, Peter Krempa wrote: > > > Incremental backup is not enabled yet, so there's no real point in > > > documenting patches implementing parts of it. > > > > > > NACK > > > > Makes sense... Unfortunately the patch has been pushed already. Do > > you want me to revert it? Do you want to do that yourself? > > Sure, here's the patch: > > https://www.redhat.com/archives/libvir-list/2020-September/msg00349.html ACKed, thanks. > I've specifically also mentioned before that I don't see a point > in documenting stuff for incremental backup: > > https://www.redhat.com/archives/libvir-list/2020-July/msg00267.html Yeah, that's entirely my bad for forgetting. Sorry O:-) -- Andrea Bolognani / Red Hat / Virtualization
© 2016 - 2024 Red Hat, Inc.