[PATCH] docs: add kbase entry for migrationinternals

Fangge Jin posted 1 patch 4 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200820100924.28504-1-fjin@redhat.com
docs/kbase.rst | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] docs: add kbase entry for migrationinternals
Posted by Fangge Jin 4 years, 3 months ago
Commit c051e56d27 added migrationinternals.rst in kbase, but the
entry was missing.

Signed-off-by: Fangge Jin <fjin@redhat.com>
---
 docs/kbase.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/docs/kbase.rst b/docs/kbase.rst
index 78daaa5989..546be6785e 100644
--- a/docs/kbase.rst
+++ b/docs/kbase.rst
@@ -44,3 +44,7 @@ Knowledge base
 
    `Incremental backup internals <kbase/incrementalbackupinternals.html>`__
       Incremental backup implementation details relevant for users
+
+   `VM migration internals <kbase/migrationinternals.html>`__
+      VM migration implementation details, complementing the info in
+      `migration <migration.html>`__
-- 
2.20.1

Re: [PATCH] docs: add kbase entry for migrationinternals
Posted by Michal Privoznik 4 years, 3 months ago
On 8/20/20 12:09 PM, Fangge Jin wrote:
> Commit c051e56d27 added migrationinternals.rst in kbase, but the
> entry was missing.
> 
> Signed-off-by: Fangge Jin <fjin@redhat.com>
> ---
>   docs/kbase.rst | 4 ++++
>   1 file changed, 4 insertions(+)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

And I think it's safe for freeze but I remember discussion where some 
other developers advocated for pushing only critical patches during 
freeze, so I will postpone pushing until the freeze is over.

Michal

Re: [PATCH] docs: add kbase entry for migrationinternals
Posted by Ján Tomko 4 years, 3 months ago
On a Thursday in 2020, Fangge Jin wrote:
>Commit c051e56d27 added migrationinternals.rst in kbase, but the
>entry was missing.
>
>Signed-off-by: Fangge Jin <fjin@redhat.com>
>---
> docs/kbase.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano