[GSoC][PATCH 4/7] qemu_domain: funciton declarations moved to correct file

Prathamesh Chavan posted 7 patches 5 years, 6 months ago
[GSoC][PATCH 4/7] qemu_domain: funciton declarations moved to correct file
Posted by Prathamesh Chavan 5 years, 6 months ago
Functions `qemuDomainRemoveInactiveJob` and
`qemuDomainRemoveInactiveJobLocked` had their declaration
mispalced in `qemu_domainjob` and were moved to
`qemu_domain`.

Signed-off-by: Prathamesh Chavan <pc44800@gmail.com>
---
 src/qemu/qemu_domain.h    | 6 ++++++
 src/qemu/qemu_domainjob.h | 6 ------
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index a247629c17..2cc10a30a4 100644
--- a/src/qemu/qemu_domain.h
+++ b/src/qemu/qemu_domain.h
@@ -540,6 +540,12 @@ struct _qemuDomainJobPrivate {
 };
 
 
+void qemuDomainRemoveInactiveJob(virQEMUDriverPtr driver,
+                                 virDomainObjPtr vm);
+
+void qemuDomainRemoveInactiveJobLocked(virQEMUDriverPtr driver,
+                                       virDomainObjPtr vm);
+
 void qemuDomainEventEmitJobCompleted(virQEMUDriverPtr driver,
                                      virDomainObjPtr vm);
 
diff --git a/src/qemu/qemu_domainjob.h b/src/qemu/qemu_domainjob.h
index ee71ae77e8..437a27f74a 100644
--- a/src/qemu/qemu_domainjob.h
+++ b/src/qemu/qemu_domainjob.h
@@ -197,12 +197,6 @@ int qemuDomainObjRestoreJob(virDomainObjPtr obj,
 void qemuDomainObjDiscardAsyncJob(virDomainObjPtr obj);
 void qemuDomainObjReleaseAsyncJob(virDomainObjPtr obj);
 
-void qemuDomainRemoveInactiveJob(virQEMUDriverPtr driver,
-                                 virDomainObjPtr vm);
-
-void qemuDomainRemoveInactiveJobLocked(virQEMUDriverPtr driver,
-                                       virDomainObjPtr vm);
-
 bool qemuDomainTrackJob(qemuDomainJob job);
 
 void qemuDomainObjFreeJob(qemuDomainJobObjPtr job);
-- 
2.25.1

Re: [GSoC][PATCH 4/7] qemu_domain: funciton declarations moved to correct file
Posted by Erik Skultety 5 years, 5 months ago
On Tue, Aug 04, 2020 at 08:06:46PM +0530, Prathamesh Chavan wrote:
> Functions `qemuDomainRemoveInactiveJob` and
> `qemuDomainRemoveInactiveJobLocked` had their declaration
> mispalced in `qemu_domainjob` and were moved to

s/mispalced/misplaced

> `qemu_domain`.
>
> Signed-off-by: Prathamesh Chavan <pc44800@gmail.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>