spec: Don't require mdevctl on RHEL 7

[libvirt PATCH] spec: Don't require mdevctl on RHEL 7

Andrea Bolognani posted 1 patch 3 years, 9 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200718224605.34893-1-abologna@redhat.com

libvirt.spec.in | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[libvirt PATCH] spec: Don't require mdevctl on RHEL 7

Posted by Andrea Bolognani 3 years, 9 months ago

mdevctl is a relatively new tool that's packaged for Fedora and
RHEL 8, but not for RHEL 7. Make the dependency conditional to
avoid the libvirt-daemon-driver-nodedev package becoming
uninstallable on that platform.

Fixes: 9691440ecbc7d9383a1410f1067a4f9221f2de2c
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index f335a7e06e..c700bf8e5c 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -526,7 +526,9 @@ Requires: libvirt-libs = %{version}-%{release}
 # needed for device enumeration
 Requires: systemd >= 185
 # For managing persistent mediated devices
+%if 0%{?fedora} || 0%{?rhel} > 7
 Requires: mdevctl
+%endif
 
 %description daemon-driver-nodedev
 The nodedev driver plugin for the libvirtd daemon, providing
-- 
2.25.4

Re: [libvirt PATCH] spec: Don't require mdevctl on RHEL 7

Posted by Erik Skultety 3 years, 9 months ago

On Sun, Jul 19, 2020 at 12:46:05AM +0200, Andrea Bolognani wrote:
> mdevctl is a relatively new tool that's packaged for Fedora and
> RHEL 8, but not for RHEL 7. Make the dependency conditional to
> avoid the libvirt-daemon-driver-nodedev package becoming
> uninstallable on that platform.
>
> Fixes: 9691440ecbc7d9383a1410f1067a4f9221f2de2c
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---

Oops...
Reviewed-by: Erik Skultety <eskultet@redhat.com>