[PATCH] docs: bhyve: document ignoring unknown MSRs

Roman Bogorodskiy posted 1 patch 3 years, 9 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200714154638.86831-1-bogorodskiy@gmail.com
docs/drvbhyve.html.in | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
[PATCH] docs: bhyve: document ignoring unknown MSRs
Posted by Roman Bogorodskiy 3 years, 9 months ago
Ignoring unknown MSRs using <features> element
<msrs unknown='ignore'/> was supported for quite some already,
so add documentation for it for completeness of flags coverage,
as some guests can be extra picky about flags passed to bhyve,
and it's useful to know how to control those.

Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
---
 docs/drvbhyve.html.in | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in
index 2e9cf5551b..66a13be1f6 100644
--- a/docs/drvbhyve.html.in
+++ b/docs/drvbhyve.html.in
@@ -462,6 +462,24 @@ Example:</p>
 &lt;/domain&gt;
 </pre>
 
+<h3><a id="msrs">Ignoring unknown MSRs reads and writes</a></h3>
+
+<p><span class="since">Since 5.1.0</span>, it's possible to make bhyve
+ignore accesses to unimplemented Model Specific Registers (MSRs).
+Example:</p>
+
+<pre>
+&lt;domain type="bhyve"&gt;
+    ...
+    &lt;features&gt;
+      ...
+      &lt;msrs unknown='ignore'/&gt;
+      ...
+    &lt;/features&gt;
+    ...
+&lt;/domain&gt;
+</pre>
+
 <h3><a id="bhyvecommand">Pass-through of arbitrary bhyve commands</a></h3>
 
 <p><span class="since">Since 5.1.0</span>, it's possible to pass additional command-line
-- 
2.27.0

Re: [PATCH] docs: bhyve: document ignoring unknown MSRs
Posted by Daniel P. Berrangé 3 years, 9 months ago
On Tue, Jul 14, 2020 at 07:46:38PM +0400, Roman Bogorodskiy wrote:
> Ignoring unknown MSRs using <features> element
> <msrs unknown='ignore'/> was supported for quite some already,
> so add documentation for it for completeness of flags coverage,
> as some guests can be extra picky about flags passed to bhyve,
> and it's useful to know how to control those.
> 
> Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
> ---
>  docs/drvbhyve.html.in | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] docs: bhyve: document ignoring unknown MSRs
Posted by Roman Bogorodskiy 3 years, 9 months ago
  Daniel P. Berrangé wrote:

> On Tue, Jul 14, 2020 at 07:46:38PM +0400, Roman Bogorodskiy wrote:
> > Ignoring unknown MSRs using <features> element
> > <msrs unknown='ignore'/> was supported for quite some already,
> > so add documentation for it for completeness of flags coverage,
> > as some guests can be extra picky about flags passed to bhyve,
> > and it's useful to know how to control those.
> > 
> > Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
> > ---
> >  docs/drvbhyve.html.in | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> 
> 
> Regards,
> Daniel

Pushed, thanks!

> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
> 

Roman Bogorodskiy