This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8
---
 NEWS.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index cc35cb26b2..ce5d227068 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -20,6 +20,11 @@ v6.6.0 (unreleased)
 
 * **Improvements**
 
+   * esx: Change the NIC limit for recent virtualHW versions
+
+   Specifying a virtualHW version greater or equal to 7 (ESXi 4.0) will allow
+   you to use up to 10 NICs instead of 4 as it was previously.
+
 * **Bug fixes**
 
 
-- 
2.20.1

On Thu, 2020-07-09 at 11:25 +0200, Bastien Orivel wrote:
> This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8

You're missing the Signed-off-by tag...

>  * **Improvements**
>  
> +   * esx: Change the NIC limit for recent virtualHW versions
> +
> +   Specifying a virtualHW version greater or equal to 7 (ESXi 4.0) will allow
> +   you to use up to 10 NICs instead of 4 as it was previously.

... and indentation is off (see existing entries for comparison).

I can fix both before pushing if you're okay with that, or you could
repost, whatever is better for you.

-- 
Andrea Bolognani / Red Hat / Virtualization

On 09/07/2020 12:10, Andrea Bolognani wrote:
> On Thu, 2020-07-09 at 11:25 +0200, Bastien Orivel wrote:
>> This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8
> You're missing the Signed-off-by tag...
Sorry, not used to using that git feature.
>
>>  * **Improvements**
>>  
>> +   * esx: Change the NIC limit for recent virtualHW versions
>> +
>> +   Specifying a virtualHW version greater or equal to 7 (ESXi 4.0) will allow
>> +   you to use up to 10 NICs instead of 4 as it was previously.
> ... and indentation is off (see existing entries for comparison).
>
> I can fix both before pushing if you're okay with that, or you could
> repost, whatever is better for you.
>
If you can fix it for me it'll avoid me battling git send-email for a
while to find out how to send updated patches.

On Thu, Jul 09, 2020 at 12:18:16 +0200, Bastien Orivel wrote:
> 
> 
> On 09/07/2020 12:10, Andrea Bolognani wrote:
> > On Thu, 2020-07-09 at 11:25 +0200, Bastien Orivel wrote:
> >> This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8
> > You're missing the Signed-off-by tag...
> Sorry, not used to using that git feature.
> >
> >>  * **Improvements**
> >>  
> >> +   * esx: Change the NIC limit for recent virtualHW versions
> >> +
> >> +   Specifying a virtualHW version greater or equal to 7 (ESXi 4.0) will allow
> >> +   you to use up to 10 NICs instead of 4 as it was previously.
> > ... and indentation is off (see existing entries for comparison).
> >
> > I can fix both before pushing if you're okay with that, or you could
> > repost, whatever is better for you.
> >
> If you can fix it for me it'll avoid me battling git send-email for a
> while to find out how to send updated patches.

Oops, hit send too soon.

You must do the certification of the DCO explicitly, e.g. by replying
with your signoff here at least. Otherwise we can't add the tag on your
behalf to the commit.

On Thu, Jul 09, 2020 at 12:18:16 +0200, Bastien Orivel wrote:
> 
> 
> On 09/07/2020 12:10, Andrea Bolognani wrote:
> > On Thu, 2020-07-09 at 11:25 +0200, Bastien Orivel wrote:
> >> This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8
> > You're missing the Signed-off-by tag...
> Sorry, not used to using that git feature.

Note that the presence of the 'Signed-off' tag is not just a git feature
but a certification that you are submitting the commit in accordance
with the developer certificate of origin:

https://developercertificate.org/