Several g_auto* conversion and related small bugfixes

[PATCH 09/25] util: add g_autoptr cleanup function for virFirewall objects

Posted by Laine Stump 5 years, 7 months ago

Put in a separate patch so that two future patches can be re-ordered /
selectively backported independent of each other.

Signed-off-by: Laine Stump <laine@redhat.com>
---
 src/util/virfirewall.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/util/virfirewall.h b/src/util/virfirewall.h
index 6148f46827..ff690b36f0 100644
--- a/src/util/virfirewall.h
+++ b/src/util/virfirewall.h
@@ -40,6 +40,7 @@ virFirewallPtr virFirewallNew(void);
 
 void virFirewallFree(virFirewallPtr firewall);
 
+
 /**
  * virFirewallAddRule:
  * @firewall: firewall ruleset to add to
-- 
2.25.4

Re: [PATCH 09/25] util: add g_autoptr cleanup function for virFirewall objects

Posted by Ján Tomko 5 years, 7 months ago

The cleanup function was already added by:
commit 2ad0284627ea3d6c123e0a266b9c7bb00aea4576
CommitDate: 2018-07-27 17:21:04 +0200

     util: firewall: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC

On a Wednesday in 2020, Laine Stump wrote:
>Put in a separate patch so that two future patches can be re-ordered /
>selectively backported independent of each other.
>
>Signed-off-by: Laine Stump <laine@redhat.com>
>---
> src/util/virfirewall.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/src/util/virfirewall.h b/src/util/virfirewall.h
>index 6148f46827..ff690b36f0 100644
>--- a/src/util/virfirewall.h
>+++ b/src/util/virfirewall.h
>@@ -40,6 +40,7 @@ virFirewallPtr virFirewallNew(void);
>
> void virFirewallFree(virFirewallPtr firewall);
>
>+

This is just a whitespace change that contradicts the prevailing style
in this file.

Jano

> /**
>  * virFirewallAddRule:
>  * @firewall: firewall ruleset to add to
>-- 
>2.25.4
>

Re: [PATCH 09/25] util: add g_autoptr cleanup function for virFirewall objects

Posted by Laine Stump 5 years, 7 months ago

On 6/25/20 7:17 PM, Ján Tomko wrote:
> The cleanup function was already added by:
> commit 2ad0284627ea3d6c123e0a266b9c7bb00aea4576
> CommitDate: 2018-07-27 17:21:04 +0200
>
>     util: firewall: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC
>
> On a Wednesday in 2020, Laine Stump wrote:
>> Put in a separate patch so that two future patches can be re-ordered /
>> selectively backported independent of each other.
>>
>> Signed-off-by: Laine Stump <laine@redhat.com>
>> ---
>> src/util/virfirewall.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/src/util/virfirewall.h b/src/util/virfirewall.h
>> index 6148f46827..ff690b36f0 100644
>> --- a/src/util/virfirewall.h
>> +++ b/src/util/virfirewall.h
>> @@ -40,6 +40,7 @@ virFirewallPtr virFirewallNew(void);
>>
>> void virFirewallFree(virFirewallPtr firewall);
>>
>> +
>
> This is just a whitespace change that contradicts the prevailing style
> in this file.


Right. Another patch that I intended to remove before I posted, but 
forgot because it was late and I wanted to end the day with a clean slate.


Derp.