[PATCH] spec: Add the build dependency of make

Han Han posted 1 patch 2 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200624090719.22725-1-hhan@redhat.com
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)

[PATCH] spec: Add the build dependency of make

Posted by Han Han 2 weeks ago
For some minimal OS like fedora cloud image, the make is not installed
by default.

Signed-off-by: Han Han <hhan@redhat.com>
---
 libvirt.spec.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index cd7c33ab1a..9f24e06aa4 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -269,6 +269,7 @@ BuildRequires: python36-docutils
 BuildRequires: python3-docutils
 %endif
 BuildRequires: gcc
+BuildRequires: make
 BuildRequires: git
 %if 0%{?fedora} || 0%{?rhel} > 7
 BuildRequires: perl-interpreter
-- 
2.24.0.rc1

Re: [PATCH] spec: Add the build dependency of make

Posted by Michal Privoznik 2 weeks ago
On 6/24/20 11:07 AM, Han Han wrote:
> For some minimal OS like fedora cloud image, the make is not installed
> by default.
> 
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>   libvirt.spec.in | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index cd7c33ab1a..9f24e06aa4 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -269,6 +269,7 @@ BuildRequires: python36-docutils
>   BuildRequires: python3-docutils
>   %endif
>   BuildRequires: gcc
> +BuildRequires: make
>   BuildRequires: git
>   %if 0%{?fedora} || 0%{?rhel} > 7
>   BuildRequires: perl-interpreter
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal