[PATCH v2 0/3] Support hooks placed in several files

Dmitry Nesterenko posted 3 patches 2 weeks ago
Test syntax-check failed
Failed in applying to current master (apply log)
NEWS.rst           |   6 ++
docs/hooks.html.in |  27 ++++++++
src/util/virhook.c | 164 +++++++++++++++++++++++++++++++++++++++------
3 files changed, 175 insertions(+), 22 deletions(-)

[PATCH v2 0/3] Support hooks placed in several files

Posted by Dmitry Nesterenko 2 weeks ago
Libvirt hook calls only one script (/etc/libvirt/hooks/<driver>) now.
This is not convenient if scripts for hook are provided by many vendors.
Script one vendor can replace previously installed script other vendor.
These patches are changing behaviour of hooks to usual linux scheme -
running all scripts from the directories /etc/libvirt/hooks/<driver>.d/
in alphabetical order. If we find script in old place we will execute
it as first for backward compatibility.

Dmitry Nesterenko (3):
  virhook: refactoring for support hooks placed in several files
  virhook: support hooks placed in several files
  virhook: changes in docs about support hooks placed in several files

 NEWS.rst           |   6 ++
 docs/hooks.html.in |  27 ++++++++
 src/util/virhook.c | 164 +++++++++++++++++++++++++++++++++++++++------
 3 files changed, 175 insertions(+), 22 deletions(-)

-- 
2.18.4

Re: [PATCH v2 0/3] Support hooks placed in several files

Posted by Michal Privoznik 2 weeks ago
On 6/23/20 4:45 PM, Dmitry Nesterenko wrote:
> Libvirt hook calls only one script (/etc/libvirt/hooks/<driver>) now.
> This is not convenient if scripts for hook are provided by many vendors.
> Script one vendor can replace previously installed script other vendor.
> These patches are changing behaviour of hooks to usual linux scheme -
> running all scripts from the directories /etc/libvirt/hooks/<driver>.d/
> in alphabetical order. If we find script in old place we will execute
> it as first for backward compatibility.
> 
> Dmitry Nesterenko (3):
>    virhook: refactoring for support hooks placed in several files
>    virhook: support hooks placed in several files
>    virhook: changes in docs about support hooks placed in several files
> 
>   NEWS.rst           |   6 ++
>   docs/hooks.html.in |  27 ++++++++
>   src/util/virhook.c | 164 +++++++++++++++++++++++++++++++++++++++------
>   3 files changed, 175 insertions(+), 22 deletions(-)
> 

I'm fixing all the small nits, and pushing.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Congratulations on your first libvirt contribution!

Michal