[libvirt PATCH] ci: Use fedora image for code style checking

Jonathon Jongsma posted 1 patch 3 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200618193810.8039-1-jjongsma@redhat.com
.gitlab-ci.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt PATCH] ci: Use fedora image for code style checking

Posted by Jonathon Jongsma 3 weeks ago
Centos does not have the cppi package, so some code style checks are
skipped. Switch to a fedora image to do the code style checks.

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index bfb66a652d..b8d0645e99 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -496,7 +496,7 @@ website:
 
 codestyle:
   stage: builds
-  image: $CI_REGISTRY_IMAGE/ci-centos-8:latest
+  image: $CI_REGISTRY_IMAGE/ci-fedora-32:latest
   before_script:
     - *script_variables
   script:
-- 
2.21.3

Re: [libvirt PATCH] ci: Use fedora image for code style checking

Posted by Andrea Bolognani 2 weeks ago
On Thu, 2020-06-18 at 14:38 -0500, Jonathon Jongsma wrote:
> Centos does not have the cppi package, so some code style checks are

*CentOS

> skipped. Switch to a fedora image to do the code style checks.

*Fedora

>  codestyle:
>    stage: builds
> -  image: $CI_REGISTRY_IMAGE/ci-centos-8:latest
> +  image: $CI_REGISTRY_IMAGE/ci-fedora-32:latest

The idea behind using CentOS 8 is that, unlike Fedora, it's a
long-term supported OS so we don't have to change the corresponding
job as frequently.

openSUSE 15.1 is also has long-term support and cppi, so it seems
like it would be a better candidate here.

Dan, what do you think?

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH] ci: Use fedora image for code style checking

Posted by Daniel P. Berrangé 2 weeks ago
On Fri, Jun 19, 2020 at 07:36:58PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-06-18 at 14:38 -0500, Jonathon Jongsma wrote:
> > Centos does not have the cppi package, so some code style checks are
> 
> *CentOS
> 
> > skipped. Switch to a fedora image to do the code style checks.
> 
> *Fedora
> 
> >  codestyle:
> >    stage: builds
> > -  image: $CI_REGISTRY_IMAGE/ci-centos-8:latest
> > +  image: $CI_REGISTRY_IMAGE/ci-fedora-32:latest
> 
> The idea behind using CentOS 8 is that, unlike Fedora, it's a
> long-term supported OS so we don't have to change the corresponding
> job as frequently.
> 
> openSUSE 15.1 is also has long-term support and cppi, so it seems
> like it would be a better candidate here.
> 
> Dan, what do you think?

For other apps we've tended towards Ubuntu 20.04 when CentOS wasn't
viable, as that'll be around a reasonably long time.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [libvirt PATCH] ci: Use fedora image for code style checking

Posted by Andrea Bolognani 2 weeks ago
On Mon, 2020-06-22 at 10:00 +0100, Daniel P. Berrangé wrote:
> On Fri, Jun 19, 2020 at 07:36:58PM +0200, Andrea Bolognani wrote:
> > openSUSE 15.1 is also has long-term support and cppi, so it seems
> > like it would be a better candidate here.
> > 
> > Dan, what do you think?
> 
> For other apps we've tended towards Ubuntu 20.04 when CentOS wasn't
> viable, as that'll be around a reasonably long time.

Yeah, but Ubuntu doesn't have cppi either :)

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH] ci: Use fedora image for code style checking

Posted by Daniel P. Berrangé 2 weeks ago
On Mon, Jun 22, 2020 at 12:01:42PM +0200, Andrea Bolognani wrote:
> On Mon, 2020-06-22 at 10:00 +0100, Daniel P. Berrangé wrote:
> > On Fri, Jun 19, 2020 at 07:36:58PM +0200, Andrea Bolognani wrote:
> > > openSUSE 15.1 is also has long-term support and cppi, so it seems
> > > like it would be a better candidate here.
> > > 
> > > Dan, what do you think?
> > 
> > For other apps we've tended towards Ubuntu 20.04 when CentOS wasn't
> > viable, as that'll be around a reasonably long time.
> 
> Yeah, but Ubuntu doesn't have cppi either :)

Oh well, openSUSE it is then, but I do wonder if it is really worth
having this cppi check when so many platforms are missing it.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [libvirt PATCH] ci: Use fedora image for code style checking

Posted by Andrea Bolognani 2 weeks ago
On Mon, 2020-06-22 at 11:30 +0100, Daniel P. Berrangé wrote:
> On Mon, Jun 22, 2020 at 12:01:42PM +0200, Andrea Bolognani wrote:
> > On Mon, 2020-06-22 at 10:00 +0100, Daniel P. Berrangé wrote:
> > > For other apps we've tended towards Ubuntu 20.04 when CentOS wasn't
> > > viable, as that'll be around a reasonably long time.
> > 
> > Yeah, but Ubuntu doesn't have cppi either :)
> 
> Oh well, openSUSE it is then, but I do wonder if it is really worth
> having this cppi check when so many platforms are missing it.

Fedora, Gentoo and openSUSE all have it, and since those seem to be
the operating systems used by the majority of libvirt contributors I
would say the chances of issues being spotted early is reasonably
high; once we have a variation of this commit in, we'll start
catching it in CI as well, so that doesn't sound too bad to me.

Jonathon, can you go ahead and post a v2 that uses openSUSE instead
of Fedora please? :)

-- 
Andrea Bolognani / Red Hat / Virtualization