[PATCH v7 00/10] TPM Proxy (H_TPM_COMM) support for PPC64

Daniel Henrique Barboza posted 10 patches 3 years, 10 months ago
Test syntax-check failed
Failed in applying to current master (apply log)
NEWS.rst                                      | 13 ++++
docs/formatdomain.html.in                     | 19 ++++-
docs/schemas/domaincommon.rng                 |  1 +
src/conf/domain_audit.c                       |  4 +-
src/conf/domain_conf.c                        | 50 +++++++-----
src/conf/domain_conf.h                        |  6 +-
src/qemu/qemu_alias.c                         |  9 ++-
src/qemu/qemu_capabilities.c                  |  2 +
src/qemu/qemu_capabilities.h                  |  1 +
src/qemu/qemu_cgroup.c                        | 10 ++-
src/qemu/qemu_command.c                       | 59 +++++++++++---
src/qemu/qemu_domain.c                        | 68 ++++++++++++++---
src/qemu/qemu_domain_address.c                | 11 ++-
src/qemu/qemu_extdevice.c                     | 24 +++---
src/qemu/qemu_tpm.c                           | 76 +++++++++----------
src/qemu/qemu_validate.c                      | 19 +++++
src/security/security_dac.c                   |  8 +-
src/security/security_selinux.c               | 44 +++++------
src/security/virt-aa-helper.c                 | 14 ++--
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 +
tests/qemuxml2argvdata/ppc64-tpm-double.xml   | 34 +++++++++
.../ppc64-tpmproxy-double.xml                 | 38 ++++++++++
.../ppc64-tpmproxy-single.ppc64-latest.args   | 34 +++++++++
.../ppc64-tpmproxy-single.xml                 | 33 ++++++++
.../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 37 +++++++++
.../ppc64-tpmproxy-with-tpm.xml               | 36 +++++++++
tests/qemuxml2argvtest.c                      | 33 +++++---
.../ppc64-tpmproxy-single.ppc64-latest.xml    | 42 ++++++++++
.../ppc64-tpmproxy-with-tpm.ppc64-latest.xml  | 46 +++++++++++
tests/qemuxml2xmltest.c                       |  2 +
31 files changed, 623 insertions(+), 152 deletions(-)
create mode 100644 tests/qemuxml2argvdata/ppc64-tpm-double.xml
create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-double.xml
create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.ppc64-latest.args
create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.xml
create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.ppc64-latest.args
create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.xml
create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-single.ppc64-latest.xml
create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-with-tpm.ppc64-latest.xml
[PATCH v7 00/10] TPM Proxy (H_TPM_COMM) support for PPC64
Posted by Daniel Henrique Barboza 3 years, 10 months ago
This is a rebase to fix conflicts with master (at 2072c395419b) and
to adapt to the new NEWS.rst format. Changes were simple, so I didn't
remove any reviewed-by/tested-by tags from the previous version.

changes in v7:
- fixed conflicts in patch 02 after "cpu.migratable" and "fw_cfg" caps
went upstream
- fixed a conflict in patch 05 after virSysinfoDefPtr was added to
the domain
- changed to the new NEWS.rst format instead of docs/news.xml in patch 10
 
Gitlab tree: https://gitlab.com/danielhb/libvirt/tree/spapr_tpm_proxy_v7 

v6 link: https://www.redhat.com/archives/libvir-list/2020-June/msg00051.html
v5 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00997.html
v4 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00814.html
v3 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00642.html
v2 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html
v1 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00351.html 

Daniel Henrique Barboza (10):
  docs: documentation and schema for the new TPM Proxy model
  qemu: Extend QEMU capabilities with 'spapr-tpm-proxy'
  qemu_extdevice.c: remove unneeded 'ret' variable
  qemu_tpm, security, tests: change 'switch' clauses for 'if'
  conf, qemu, security, tests: introducing 'def->tpms' array
  qemu: add validations after TPM Proxy model introduction
  tests: add XML schema tests for the TPM Proxy device
  qemu: build command line for the TPM Proxy device
  tests/qemuxml2argvtest.c: add TPM Proxy command line tests
  NEWS.rst: update for the new TPM Proxy device

 NEWS.rst                                      | 13 ++++
 docs/formatdomain.html.in                     | 19 ++++-
 docs/schemas/domaincommon.rng                 |  1 +
 src/conf/domain_audit.c                       |  4 +-
 src/conf/domain_conf.c                        | 50 +++++++-----
 src/conf/domain_conf.h                        |  6 +-
 src/qemu/qemu_alias.c                         |  9 ++-
 src/qemu/qemu_capabilities.c                  |  2 +
 src/qemu/qemu_capabilities.h                  |  1 +
 src/qemu/qemu_cgroup.c                        | 10 ++-
 src/qemu/qemu_command.c                       | 59 +++++++++++---
 src/qemu/qemu_domain.c                        | 68 ++++++++++++++---
 src/qemu/qemu_domain_address.c                | 11 ++-
 src/qemu/qemu_extdevice.c                     | 24 +++---
 src/qemu/qemu_tpm.c                           | 76 +++++++++----------
 src/qemu/qemu_validate.c                      | 19 +++++
 src/security/security_dac.c                   |  8 +-
 src/security/security_selinux.c               | 44 +++++------
 src/security/virt-aa-helper.c                 | 14 ++--
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 +
 tests/qemuxml2argvdata/ppc64-tpm-double.xml   | 34 +++++++++
 .../ppc64-tpmproxy-double.xml                 | 38 ++++++++++
 .../ppc64-tpmproxy-single.ppc64-latest.args   | 34 +++++++++
 .../ppc64-tpmproxy-single.xml                 | 33 ++++++++
 .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 37 +++++++++
 .../ppc64-tpmproxy-with-tpm.xml               | 36 +++++++++
 tests/qemuxml2argvtest.c                      | 33 +++++---
 .../ppc64-tpmproxy-single.ppc64-latest.xml    | 42 ++++++++++
 .../ppc64-tpmproxy-with-tpm.ppc64-latest.xml  | 46 +++++++++++
 tests/qemuxml2xmltest.c                       |  2 +
 31 files changed, 623 insertions(+), 152 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/ppc64-tpm-double.xml
 create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-double.xml
 create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.ppc64-latest.args
 create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.xml
 create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.ppc64-latest.args
 create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.xml
 create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-single.ppc64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-with-tpm.ppc64-latest.xml

-- 
2.26.2

Re: [PATCH v7 00/10] TPM Proxy (H_TPM_COMM) support for PPC64
Posted by Daniel Henrique Barboza 3 years, 10 months ago
Ping for reviews


Also, this series is related to a bug that wasn't available publicly
when I posted the patches:

https://bugzilla.redhat.com/show_bug.cgi?id=1838975

I believe this info belongs in the commit msg of patch 08/10.


Thanks,


DHB


On 6/10/20 3:11 PM, Daniel Henrique Barboza wrote:
> This is a rebase to fix conflicts with master (at 2072c395419b) and
> to adapt to the new NEWS.rst format. Changes were simple, so I didn't
> remove any reviewed-by/tested-by tags from the previous version.
> 
> changes in v7:
> - fixed conflicts in patch 02 after "cpu.migratable" and "fw_cfg" caps
> went upstream
> - fixed a conflict in patch 05 after virSysinfoDefPtr was added to
> the domain
> - changed to the new NEWS.rst format instead of docs/news.xml in patch 10
>   
> Gitlab tree: https://gitlab.com/danielhb/libvirt/tree/spapr_tpm_proxy_v7
> 
> v6 link: https://www.redhat.com/archives/libvir-list/2020-June/msg00051.html
> v5 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00997.html
> v4 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00814.html
> v3 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00642.html
> v2 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html
> v1 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00351.html
> 
> Daniel Henrique Barboza (10):
>    docs: documentation and schema for the new TPM Proxy model
>    qemu: Extend QEMU capabilities with 'spapr-tpm-proxy'
>    qemu_extdevice.c: remove unneeded 'ret' variable
>    qemu_tpm, security, tests: change 'switch' clauses for 'if'
>    conf, qemu, security, tests: introducing 'def->tpms' array
>    qemu: add validations after TPM Proxy model introduction
>    tests: add XML schema tests for the TPM Proxy device
>    qemu: build command line for the TPM Proxy device
>    tests/qemuxml2argvtest.c: add TPM Proxy command line tests
>    NEWS.rst: update for the new TPM Proxy device
> 
>   NEWS.rst                                      | 13 ++++
>   docs/formatdomain.html.in                     | 19 ++++-
>   docs/schemas/domaincommon.rng                 |  1 +
>   src/conf/domain_audit.c                       |  4 +-
>   src/conf/domain_conf.c                        | 50 +++++++-----
>   src/conf/domain_conf.h                        |  6 +-
>   src/qemu/qemu_alias.c                         |  9 ++-
>   src/qemu/qemu_capabilities.c                  |  2 +
>   src/qemu/qemu_capabilities.h                  |  1 +
>   src/qemu/qemu_cgroup.c                        | 10 ++-
>   src/qemu/qemu_command.c                       | 59 +++++++++++---
>   src/qemu/qemu_domain.c                        | 68 ++++++++++++++---
>   src/qemu/qemu_domain_address.c                | 11 ++-
>   src/qemu/qemu_extdevice.c                     | 24 +++---
>   src/qemu/qemu_tpm.c                           | 76 +++++++++----------
>   src/qemu/qemu_validate.c                      | 19 +++++
>   src/security/security_dac.c                   |  8 +-
>   src/security/security_selinux.c               | 44 +++++------
>   src/security/virt-aa-helper.c                 | 14 ++--
>   .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
>   .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 +
>   tests/qemuxml2argvdata/ppc64-tpm-double.xml   | 34 +++++++++
>   .../ppc64-tpmproxy-double.xml                 | 38 ++++++++++
>   .../ppc64-tpmproxy-single.ppc64-latest.args   | 34 +++++++++
>   .../ppc64-tpmproxy-single.xml                 | 33 ++++++++
>   .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 37 +++++++++
>   .../ppc64-tpmproxy-with-tpm.xml               | 36 +++++++++
>   tests/qemuxml2argvtest.c                      | 33 +++++---
>   .../ppc64-tpmproxy-single.ppc64-latest.xml    | 42 ++++++++++
>   .../ppc64-tpmproxy-with-tpm.ppc64-latest.xml  | 46 +++++++++++
>   tests/qemuxml2xmltest.c                       |  2 +
>   31 files changed, 623 insertions(+), 152 deletions(-)
>   create mode 100644 tests/qemuxml2argvdata/ppc64-tpm-double.xml
>   create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-double.xml
>   create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.ppc64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.xml
>   create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.ppc64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.xml
>   create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-single.ppc64-latest.xml
>   create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-with-tpm.ppc64-latest.xml
> 

Re: [PATCH v7 00/10] TPM Proxy (H_TPM_COMM) support for PPC64
Posted by Ján Tomko 3 years, 10 months ago
On a Sunday in 2020, Daniel Henrique Barboza wrote:
>Ping for reviews
>
>
>Also, this series is related to a bug that wasn't available publicly
>when I posted the patches:
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1838975
>

Oops, I forgot to link the bug in the commit message before pushing
this.

Jano

>I believe this info belongs in the commit msg of patch 08/10.
>
>
>Thanks,
>
>
>DHB
>
>