conf: fix alignment in virObjectEvent to be 8 not 4 bytes

[libvirt PATCH] conf: fix alignment in virObjectEvent to be 8 not 4 bytes

Daniel P. Berrangé posted 1 patch 3 years, 10 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200604101805.3205990-1-berrange@redhat.com

src/conf/object_event_private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH] conf: fix alignment in virObjectEvent to be 8 not 4 bytes

Posted by Daniel P. Berrangé 3 years, 10 months ago

The previous fix accidentally picked up a debug change that put
alignment back at 4, not 8, bytes as it claimed:

  commit 37ae0426420a2f682cc96ee457a8cae9c0db27d3
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Wed Jun 3 11:18:23 2020 +0100

    conf: force 8 byte alignment for virObjectEvent

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

Pushed under the face-palm build breaker fix rule

 src/conf/object_event_private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/object_event_private.h b/src/conf/object_event_private.h
index 126464a9a5..80af043b9b 100644
--- a/src/conf/object_event_private.h
+++ b/src/conf/object_event_private.h
@@ -42,7 +42,7 @@ typedef void
                               virConnectObjectEventGenericCallback cb,
                               void *cbopaque);
 
-struct  __attribute__((aligned(4))) _virObjectEvent {
+struct  __attribute__((aligned(8))) _virObjectEvent {
     virObject parent;
     int eventID;
     virObjectMeta meta;
-- 
2.26.2