1. Patchew
  2. Libvirt
  3. [libvirt-csharp 0/3] Enable use of GitLab CI and merge requests
  4. View patch

[libvirt-csharp 1/3] Update to target newer 4.0 .NET framework version

Daniel P. Berrangé posted 3 patches 5 years, 9 months ago
There is a newer version of this series
[libvirt-csharp 1/3] Update to target newer 4.0 .NET framework version
Posted by Daniel P. Berrangé 5 years, 9 months ago 
The 3.5 .NET version is no longer supported by the mono / monodevelop
toolchain.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 .../virConnectOpen/virConnectOpen.csproj      |  4 +-
 .../virConnectOpenAuth.csproj                 |  4 +-
 .../virConnectSetErrorFunc.csproj             |  4 +-
 .../virDomainStats/virDomainStats.csproj      | 57 ++++++++++++++++++-
 .../virEventRegisterImpl.csproj               |  4 +-
 projects/MonoDevelop/LibvirtBindings.csproj   |  6 +-
 projects/MonoDevelop/LibvirtBindings.sln      |  6 +-
 7 files changed, 65 insertions(+), 20 deletions(-)

diff --git a/examples/MonoDevelop/virConnectOpen/virConnectOpen.csproj b/examples/MonoDevelop/virConnectOpen/virConnectOpen.csproj
index e0bbb1b..131bbfc 100644
--- a/examples/MonoDevelop/virConnectOpen/virConnectOpen.csproj
+++ b/examples/MonoDevelop/virConnectOpen/virConnectOpen.csproj
@@ -1,10 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
-<Project DefaultTargets="Build" ToolsVersion="3.5" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
-    <ProductVersion>9.0.21022</ProductVersion>
-    <SchemaVersion>2.0</SchemaVersion>
     <ProjectGuid>{FFCD939E-7F9A-44D5-AEBC-84F40942E8B5}</ProjectGuid>
     <OutputType>WinExe</OutputType>
     <RootNamespace>virConnectOpen</RootNamespace>
diff --git a/examples/MonoDevelop/virConnectOpenAuth/virConnectOpenAuth.csproj b/examples/MonoDevelop/virConnectOpenAuth/virConnectOpenAuth.csproj
index 32b20d4..4e05439 100644
--- a/examples/MonoDevelop/virConnectOpenAuth/virConnectOpenAuth.csproj
+++ b/examples/MonoDevelop/virConnectOpenAuth/virConnectOpenAuth.csproj
@@ -1,10 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
-<Project DefaultTargets="Build" ToolsVersion="3.5" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
-    <ProductVersion>9.0.21022</ProductVersion>
-    <SchemaVersion>2.0</SchemaVersion>
     <ProjectGuid>{3259AE36-B12F-435E-9124-F6CAA781AD5C}</ProjectGuid>
     <OutputType>WinExe</OutputType>
     <RootNamespace>virConnectOpenAuth</RootNamespace>
diff --git a/examples/MonoDevelop/virConnectSetErrorFunc/virConnectSetErrorFunc.csproj b/examples/MonoDevelop/virConnectSetErrorFunc/virConnectSetErrorFunc.csproj
index 2a77393..f5e6254 100644
--- a/examples/MonoDevelop/virConnectSetErrorFunc/virConnectSetErrorFunc.csproj
+++ b/examples/MonoDevelop/virConnectSetErrorFunc/virConnectSetErrorFunc.csproj
@@ -1,10 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
-<Project DefaultTargets="Build" ToolsVersion="3.5" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
-    <ProductVersion>9.0.21022</ProductVersion>
-    <SchemaVersion>2.0</SchemaVersion>
     <ProjectGuid>{243DD685-9AB3-4CD0-93D5-92034C1D97D8}</ProjectGuid>
     <OutputType>WinExe</OutputType>
     <RootNamespace>virConnectSetErrorFunc</RootNamespace>
diff --git a/examples/MonoDevelop/virDomainStats/virDomainStats.csproj b/examples/MonoDevelop/virDomainStats/virDomainStats.csproj
index 355d8ef..05b2ecb 100644
--- a/examples/MonoDevelop/virDomainStats/virDomainStats.csproj
+++ b/examples/MonoDevelop/virDomainStats/virDomainStats.csproj
@@ -1 +1,56 @@
-<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="3.5" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <PropertyGroup>
    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
    <ProductVersion>9.0.21022</ProductVersion>
    <SchemaVersion>2.0</SchemaVersion>
    <ProjectGuid>{767373FC-96BE-420A-8219-97146D33B2CB}</ProjectGuid>
    <OutputType>WinExe</OutputType>
    <RootNamespace>virDomainStats</RootNamespace>
    <AssemblyName>virDomainStats</AssemblyName>
    <TargetFrameworkVersion>v3.5</TargetFrameworkVersion>
  </PropertyGroup>
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
    <DebugSymbols>true</DebugSymbols>
    <DebugType>full</DebugType>
    <Optimize>false</Optimize>
    <OutputPath>bin\Debug</OutputPath>
    <DefineConstants>DEBUG</DefineConstants>
    <ErrorReport>prompt</ErrorReport>
    <WarningLevel>4</WarningLevel>
    <ConsolePause>false</ConsolePause>
  </PropertyGroup>
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
    <DebugType>none</DebugType>
    <Optimize>false</Optimize>
    <OutputPath>bin\Release</OutputPath>
    <ErrorReport>prompt</ErrorReport>
    <WarningLevel>4</WarningLevel>
    <ConsolePause>false</ConsolePause>
  </PropertyGroup>
  <ItemGroup>
    <Reference Include="System" />
    <Reference Include="Mono.Posix" />
    <Reference Include="gtk-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
    <Reference Include="gdk-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
    <Reference Include="glib-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
    <Reference Include="glade-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
    <Reference Include="pango-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
    <Reference Include="atk-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
    <Reference Include="System.Xml" />
    <Reference Include="System.Core">
    </Reference>
  </ItemGroup>
  <ItemGroup>
    <EmbeddedResource Include="gtk-gui\gui.stetic">
      <LogicalName>gui.stetic</LogicalName>
    </EmbeddedResource>
  </ItemGroup>
  <ItemGroup>
    <Compile Include="gtk-gui\generated.cs" />
    <Compile Include="MainWindow.cs" />
    <Compile Include="gtk-gui\MainWindow.cs" />
    <Compile Include="Main.cs" />
    <Compile Include="AssemblyInfo.cs" />
  </ItemGroup>
  <ItemGroup>
    <ProjectReference Include="..\..\..\projects\MonoDevelop\LibvirtBindings.csproj">
      <Project>{C51C70EB-9040-4F8E-9A18-DF2A77D04A37}</Project>
      <Name>LibvirtBindings</Name>
    </ProjectReference>
  </ItemGroup>
  <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
</Project>
\ No newline at end of file
+<?xml version="1.0" encoding="utf-8"?>
+<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <PropertyGroup>
+    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
+    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
+    <ProjectGuid>{767373FC-96BE-420A-8219-97146D33B2CB}</ProjectGuid>
+    <OutputType>WinExe</OutputType>
+    <RootNamespace>virDomainStats</RootNamespace>
+    <AssemblyName>virDomainStats</AssemblyName>
+    <TargetFrameworkVersion>v3.5</TargetFrameworkVersion>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
+    <DebugSymbols>true</DebugSymbols>
+    <DebugType>full</DebugType>
+    <Optimize>false</Optimize>
+    <OutputPath>bin\Debug</OutputPath>
+    <DefineConstants>DEBUG</DefineConstants>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+    <ConsolePause>false</ConsolePause>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
+    <DebugType>none</DebugType>
+    <Optimize>false</Optimize>
+    <OutputPath>bin\Release</OutputPath>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+    <ConsolePause>false</ConsolePause>
+  </PropertyGroup>
+  <ItemGroup>
+    <Reference Include="System" />
+    <Reference Include="Mono.Posix" />
+    <Reference Include="gtk-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
+    <Reference Include="gdk-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
+    <Reference Include="glib-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
+    <Reference Include="glade-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
+    <Reference Include="pango-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
+    <Reference Include="atk-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" />
+    <Reference Include="System.Xml" />
+    <Reference Include="System.Core">
+    </Reference>
+  </ItemGroup>
+  <ItemGroup>
+    <EmbeddedResource Include="gtk-gui\gui.stetic">
+      <LogicalName>gui.stetic</LogicalName>
+    </EmbeddedResource>
+  </ItemGroup>
+  <ItemGroup>
+    <Compile Include="gtk-gui\generated.cs" />
+    <Compile Include="MainWindow.cs" />
+    <Compile Include="gtk-gui\MainWindow.cs" />
+    <Compile Include="Main.cs" />
+    <Compile Include="AssemblyInfo.cs" />
+  </ItemGroup>
+  <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
+</Project>
\ No newline at end of file
diff --git a/examples/MonoDevelop/virEventRegisterImpl/virEventRegisterImpl.csproj b/examples/MonoDevelop/virEventRegisterImpl/virEventRegisterImpl.csproj
index 5165c88..858b89c 100644
--- a/examples/MonoDevelop/virEventRegisterImpl/virEventRegisterImpl.csproj
+++ b/examples/MonoDevelop/virEventRegisterImpl/virEventRegisterImpl.csproj
@@ -1,10 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
-<Project DefaultTargets="Build" ToolsVersion="3.5" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
-    <ProductVersion>9.0.21022</ProductVersion>
-    <SchemaVersion>2.0</SchemaVersion>
     <ProjectGuid>{4576BB61-F143-4BC8-BD1D-D50F710CEA10}</ProjectGuid>
     <OutputType>WinExe</OutputType>
     <RootNamespace>virEventRegisterImpl</RootNamespace>
diff --git a/projects/MonoDevelop/LibvirtBindings.csproj b/projects/MonoDevelop/LibvirtBindings.csproj
index 2473625..3a35541 100644
--- a/projects/MonoDevelop/LibvirtBindings.csproj
+++ b/projects/MonoDevelop/LibvirtBindings.csproj
@@ -1,15 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
-<Project DefaultTargets="Build" ToolsVersion="3.5" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
-    <ProductVersion>9.0.21022</ProductVersion>
-    <SchemaVersion>2.0</SchemaVersion>
     <ProjectGuid>{C51C70EB-9040-4F8E-9A18-DF2A77D04A37}</ProjectGuid>
     <OutputType>Library</OutputType>
     <RootNamespace>LibvirtBindings</RootNamespace>
     <AssemblyName>LibvirtBindings</AssemblyName>
-    <TargetFrameworkVersion>v3.5</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>
diff --git a/projects/MonoDevelop/LibvirtBindings.sln b/projects/MonoDevelop/LibvirtBindings.sln
index a737c5a..a38e18c 100644
--- a/projects/MonoDevelop/LibvirtBindings.sln
+++ b/projects/MonoDevelop/LibvirtBindings.sln
@@ -1,6 +1,6 @@
-
-Microsoft Visual Studio Solution File, Format Version 10.00
-# Visual Studio 2008
+
+Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio 2012
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "LibvirtBindings", "LibvirtBindings.csproj", "{C51C70EB-9040-4F8E-9A18-DF2A77D04A37}"
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "examples", "examples", "{504BA6A7-9D0E-44BA-827D-D797773347FD}"
-- 
2.26.2
Re: [libvirt-csharp 1/3] Update to target newer 4.0 .NET framework version
Posted by Andrea Bolognani 5 years, 8 months ago 
On Tue, 2020-05-12 at 11:23 +0100, Daniel P. Berrangé wrote:
> +++ b/examples/MonoDevelop/virDomainStats/virDomainStats.csproj
> @@ -1 +1,56 @@
> -<?xml version="1.0" encoding="utf-8"?>
> <Project DefaultTargets="Build" ToolsVersion="3.5" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
>   <PropertyGroup>
>     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
>     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
>     <ProductVersion>9.0.21022</ProductVersion>
>     <SchemaVersion>2.0</SchemaVersion>
>     <ProjectGuid>{767373FC-96BE-420A-8219-97146D33B2CB}</ProjectGuid>
>     <OutputType>WinExe</OutputType>
>     <RootNamespace>virDomainStats</RootNamespace>
>     <AssemblyName>virDomainStats</AssemblyName>
>     <TargetFrameworkVersion>v3.5</TargetFrameworkVersion>

The patch seems to have gotten corrupted somehow, since all the
leading "-"s are missing from this part and the diff is larger than
it is for other files for not apparent reason.

Anyway, the changes look reasonable so, assuming your local version
of the patch is not corrupted and you've tested it thoroughly,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization
Re: [libvirt-csharp 1/3] Update to target newer 4.0 .NET framework version
Posted by Daniel P. Berrangé 5 years, 8 months ago 
On Thu, May 14, 2020 at 06:46:55PM +0200, Andrea Bolognani wrote:
> On Tue, 2020-05-12 at 11:23 +0100, Daniel P. Berrangé wrote:
> > +++ b/examples/MonoDevelop/virDomainStats/virDomainStats.csproj
> > @@ -1 +1,56 @@
> > -<?xml version="1.0" encoding="utf-8"?>
> > <Project DefaultTargets="Build" ToolsVersion="3.5" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
> >   <PropertyGroup>
> >     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
> >     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
> >     <ProductVersion>9.0.21022</ProductVersion>
> >     <SchemaVersion>2.0</SchemaVersion>
> >     <ProjectGuid>{767373FC-96BE-420A-8219-97146D33B2CB}</ProjectGuid>
> >     <OutputType>WinExe</OutputType>
> >     <RootNamespace>virDomainStats</RootNamespace>
> >     <AssemblyName>virDomainStats</AssemblyName>
> >     <TargetFrameworkVersion>v3.5</TargetFrameworkVersion>
> 
> The patch seems to have gotten corrupted somehow, since all the
> leading "-"s are missing from this part and the diff is larger than
> it is for other files for not apparent reason.

I think your mail client has just inserted fake line breaks. This original
file had its entire contents on a single line, which is fixed in the new
version :-)

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.