[libvirt PATCH] tools: mention srve-update-tls supports virtproxyd

Daniel P. Berrangé posted 1 patch 3 years, 11 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200512094945.1193786-1-berrange@redhat.com
docs/manpages/virt-admin.rst | 3 ++-
tools/virt-admin.c           | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
[libvirt PATCH] tools: mention srve-update-tls supports virtproxyd
Posted by Daniel P. Berrangé 3 years, 11 months ago
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 docs/manpages/virt-admin.rst | 3 ++-
 tools/virt-admin.c           | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/docs/manpages/virt-admin.rst b/docs/manpages/virt-admin.rst
index 3e0d127790..d5cb23a1c5 100644
--- a/docs/manpages/virt-admin.rst
+++ b/docs/manpages/virt-admin.rst
@@ -455,7 +455,8 @@ Update tls context on *server*.
 
 - *server*
 
-  Available servers on a daemon. Currently only supports 'libvirtd'.
+  Available servers on a daemon. Currently only supports 'libvirtd' or
+  'virtproxyd'.
 
 
 CLIENT COMMANDS
diff --git a/tools/virt-admin.c b/tools/virt-admin.c
index a8e5e0a5af..6ff9729f66 100644
--- a/tools/virt-admin.c
+++ b/tools/virt-admin.c
@@ -978,7 +978,7 @@ static const vshCmdOptDef opts_srv_update_tls_file[] = {
      .type = VSH_OT_DATA,
      .flags = VSH_OFLAG_REQ,
      .help = N_("Available servers on a daemon. "
-                "Currently only supports 'libvirtd'.")
+                "Currently only supports 'libvirtd' or 'virtproxyd'.")
     },
     {.name = NULL}
 };
-- 
2.26.2

Re: [libvirt PATCH] tools: mention srve-update-tls supports virtproxyd
Posted by Erik Skultety 3 years, 11 months ago
s/srve-update-tls/server-update-tls in the commit subject

Reviewed-by: Erik Skultety <eskultet@redhat.com>

Re: [libvirt PATCH] tools: mention srve-update-tls supports virtproxyd
Posted by Daniel P. Berrangé 3 years, 11 months ago
On Wed, May 13, 2020 at 09:34:56AM +0200, Erik Skultety wrote:
> s/srve-update-tls/server-update-tls in the commit subject

Oh fun, the source code comments all say  "srv-XXX" but the
actual command impls are "server-XXX"

> 
> Reviewed-by: Erik Skultety <eskultet@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|