[libvirt-ocaml PATCH 2/2] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

Daniel P. Berrangé posted 2 patches 5 years, 9 months ago
There is a newer version of this series
[libvirt-ocaml PATCH 2/2] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests
Posted by Daniel P. Berrangé 5 years, 9 months ago
With the introduction of automated CI pipelines, we are now ready to switch
to using merge requests for the project. With this switch we longer wish
to have patches sent to the mailing list.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 CONTRIBUTING.rst | 28 ++++++++++++++++++++++++++++
 MANIFEST         |  1 +
 2 files changed, 29 insertions(+)
 create mode 100644 CONTRIBUTING.rst

diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
new file mode 100644
index 0000000..8db0258
--- /dev/null
+++ b/CONTRIBUTING.rst
@@ -0,0 +1,28 @@
+=============================
+Contributing to libvirt-ocaml
+=============================
+
+The libvirt Ocaml API binding accepts code contributions via merge requests
+on the GitLab project:
+
+   https://gitlab.com/libvirt/libvirt-ocaml/-/merge_requests
+
+It is required that automated CI pipelines succeed before a merge request
+will be accepted. The global pipeline status for the ``master`` branch is
+visible at:
+
+   https://gitlab.com/libvirt/libvirt-ocaml/pipelines
+
+CI pipline results for merge requests will be visible via the contributors'
+own private repository fork:
+
+   https://gitlab.com/yourusername/libvirt-ocaml/pipelines
+
+Contributions submitted to the project must be in compliance with the
+Developer Certificate of Origin Version 1.1. This is documented at:
+
+   https://developercertificate.org/
+
+In indicate compliance, each commit in a series must have a "Signed-off-by"
+tag with the submittor's name and email address. This can be added by passing
+the ``-s`` flag to ``git commit`` when creating the patches.
diff --git a/MANIFEST b/MANIFEST
index b6a7707..4fec735 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -4,6 +4,7 @@ ChangeLog
 config.guess
 config.sub
 configure.ac
+CONTRIBUTING.rst
 COPYING
 COPYING.LIB
 contrib/0001-Add-Libvirt.Domain.get_cpu_stats_total.patch
-- 
2.26.2

Re: [libvirt-ocaml PATCH 2/2] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests
Posted by Andrea Bolognani 5 years, 9 months ago
On Wed, 2020-05-06 at 16:24 +0100, Daniel P. Berrangé wrote:
> +++ b/CONTRIBUTING.rst
> @@ -0,0 +1,28 @@
> +=============================
> +Contributing to libvirt-ocaml
> +=============================
> +
> +The libvirt Ocaml API binding accepts code contributions via merge requests
> +on the GitLab project:

s/binding/bindings/

[...]
> +Contributions submitted to the project must be in compliance with the
> +Developer Certificate of Origin Version 1.1. This is documented at:
> +
> +   https://developercertificate.org/

Links should not be indented.

> +In indicate compliance, each commit in a series must have a "Signed-off-by"
> +tag with the submittor's name and email address. This can be added by passing
> +the ``-s`` flag to ``git commit`` when creating the patches.

s/submittor/submitter/

-- 
Andrea Bolognani / Red Hat / Virtualization