[libvirt PATCH] docs: documented protected branches and tags

Daniel P. Berrangé posted 1 patch 3 years, 11 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200506110950.1071108-1-berrange@redhat.com
docs/newreposetup.rst | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
[libvirt PATCH] docs: documented protected branches and tags
Posted by Daniel P. Berrangé 3 years, 11 months ago
We need to prevent accidental deletion of release tags and maint
branches.

We need to ensure that shared CI runners are enabled on all repos.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 docs/newreposetup.rst | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/docs/newreposetup.rst b/docs/newreposetup.rst
index ce54aa09d3..cac4f84813 100644
--- a/docs/newreposetup.rst
+++ b/docs/newreposetup.rst
@@ -71,6 +71,26 @@ required under the **Settings** page:
 
     * *Require approval from code owners*: disabled
 
+    * *Branch*: ``v*-maint``
+
+    * *Allowed to merge*: Developers + Maintainers
+
+    * *Allowed to push*: None (or Developers + Maintainers if MRs not used)
+
+    * *Require approval from code owners*: disabled
+
+  * **Protected tags**
+
+    * *Tag*: ``v*``
+
+    * *Allowed to create*: Developers + Maintainers
+
+* **CI/CD**
+
+  * **Runners**
+
+    * *Shared runners*: Enable shared runners
+
 GitHub configuration
 ====================
 
-- 
2.26.2

Re: [libvirt PATCH] docs: documented protected branches and tags
Posted by Andrea Bolognani 3 years, 11 months ago
On Wed, 2020-05-06 at 12:09 +0100, Daniel P. Berrangé wrote:
> +    * *Branch*: ``v*-maint``
> +
> +    * *Allowed to merge*: Developers + Maintainers
> +
> +    * *Allowed to push*: None (or Developers + Maintainers if MRs not used)
> +
> +    * *Require approval from code owners*: disabled

These settings are the same for the master branch, no? So we could
just use

  * *Branch*: ``master``, ``v*-maint``

instead of repeating the same instructions twice.


With that changed,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH] docs: documented protected branches and tags
Posted by Daniel P. Berrangé 3 years, 11 months ago
On Wed, May 06, 2020 at 03:02:07PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-05-06 at 12:09 +0100, Daniel P. Berrangé wrote:
> > +    * *Branch*: ``v*-maint``
> > +
> > +    * *Allowed to merge*: Developers + Maintainers
> > +
> > +    * *Allowed to push*: None (or Developers + Maintainers if MRs not used)
> > +
> > +    * *Require approval from code owners*: disabled
> 
> These settings are the same for the master branch, no? So we could
> just use
> 
>   * *Branch*: ``master``, ``v*-maint``
> 
> instead of repeating the same instructions twice.

Sure, we can do that.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|