[libvirt PATCHv2] docs: note that <dnsmasq:option> was added in libvirt 5.6.0

Laine Stump posted 1 patch 3 years, 11 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200503191846.69141-1-laine@redhat.com
docs/formatnetwork.html.in | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
[libvirt PATCHv2] docs: note that <dnsmasq:option> was added in libvirt 5.6.0
Posted by Laine Stump 3 years, 11 months ago
To make it simpler to answer questions of "Why doesn't this thing work
for me?"

Signed-off-by: Laine Stump <laine@redhat.com>
---

Sigh. As danpb pointed out when I sent this before, I had copy/pasted
a "since" clause (and taken the time to make sure I could still do a
build) but hadn't bothered to replace the version number itself in the
bit that I pasted :-/

(this is why I don't allow the "trivial" rule for pushing patches to
apply to myself)

 docs/formatnetwork.html.in | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in
index 2bccac014b..9f86e9567d 100644
--- a/docs/formatnetwork.html.in
+++ b/docs/formatnetwork.html.in
@@ -1124,9 +1124,11 @@
     <h3><a id="elementsNamespaces">Network namespaces</a></h3>
 
     <p>
-      A special XML namespace is available for passing options directly to the
-      underlying dnsmasq configuration file. Usage of XML namespaces comes with no
-      support guarantees, so use at your own risk.
+      A special XML namespace is available for passing options
+      directly to the underlying dnsmasq configuration
+      file <span class="since">Since 5.6.0</span>. Usage of XML
+      namespaces comes with no support guarantees, so use at your own
+      risk.
     </p>
 
     <p>
-- 
2.25.4

Re: [libvirt PATCHv2] docs: note that <dnsmasq:option> was added in libvirt 5.6.0
Posted by Andrea Bolognani 3 years, 11 months ago
On Sun, 2020-05-03 at 15:18 -0400, Laine Stump wrote:
> +++ b/docs/formatnetwork.html.in
> @@ -1124,9 +1124,11 @@
>      <h3><a id="elementsNamespaces">Network namespaces</a></h3>
>  
>      <p>
> -      A special XML namespace is available for passing options directly to the
> -      underlying dnsmasq configuration file. Usage of XML namespaces comes with no
> -      support guarantees, so use at your own risk.
> +      A special XML namespace is available for passing options
> +      directly to the underlying dnsmasq configuration
> +      file <span class="since">Since 5.6.0</span>. Usage of XML
> +      namespaces comes with no support guarantees, so use at your own
> +      risk.

I think s/Since/since/ would work better in this specific scenario.

Regardless,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

and safe for freeze.

-- 
Andrea Bolognani / Red Hat / Virtualization