[PATCH] news: Include new DHCP network <lease/> feature

Julio Faracco posted 1 patch 4 years ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200423131915.73417-1-jcfaracco@gmail.com
There is a newer version of this series
docs/news.xml | 12 ++++++++++++
1 file changed, 12 insertions(+)
[PATCH] news: Include new DHCP network <lease/> feature
Posted by Julio Faracco 4 years ago
This commit includes an entry for new network DHCP lease time
information inside news.xml.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
---
 docs/news.xml | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 956018b512..3a013ffbbd 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -88,6 +88,18 @@
           hotplugging PCI devices.
         </description>
       </change>
+      <change>
+        <summary>
+          Lease time option included for network DHCP settings
+        </summary>
+        <description>
+          Dnsmasq does not support to configure a global lease time. There
+          is no configuration option that could specify lease time. The
+          only way to configure lease time is setting it for each range's
+          and host's lines mainly. Libvirt now can configure lease time
+          for <code>range</code> and <code>host</code>.
+        </description>
+      </change>
     </section>
     <section title="Improvements">
     </section>
-- 
2.25.3


Re: [PATCH] news: Include new DHCP network <lease/> feature
Posted by Michal Privoznik 4 years ago
On 4/23/20 3:19 PM, Julio Faracco wrote:
> This commit includes an entry for new network DHCP lease time
> information inside news.xml.
> 
> Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
> ---
>   docs/news.xml | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 956018b512..3a013ffbbd 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -88,6 +88,18 @@
>             hotplugging PCI devices.
>           </description>
>         </change>
> +      <change>
> +        <summary>
> +          Lease time option included for network DHCP settings
> +        </summary>
> +        <description>
> +          Dnsmasq does not support to configure a global lease time. There
> +          is no configuration option that could specify lease time. The
> +          only way to configure lease time is setting it for each range's
> +          and host's lines mainly. Libvirt now can configure lease time
> +          for <code>range</code> and <code>host</code>.
> +        </description>
> +      </change>
>       </section>
>       <section title="Improvements">
>       </section>
> 

I don't think we need to document dnsmasq's limitations. How about simple:

Users can now configure expiry time for leases for networks where
libvirt manages DHCP. The time can be specified for whole range
and/or fine tuned per individual host.


Michal

Re: [PATCH] news: Include new DHCP network <lease/> feature
Posted by Julio Faracco 4 years ago
Em qui., 23 de abr. de 2020 às 11:10, Michal Privoznik
<mprivozn@redhat.com> escreveu:
>
> On 4/23/20 3:19 PM, Julio Faracco wrote:
> > This commit includes an entry for new network DHCP lease time
> > information inside news.xml.
> >
> > Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
> > ---
> >   docs/news.xml | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/docs/news.xml b/docs/news.xml
> > index 956018b512..3a013ffbbd 100644
> > --- a/docs/news.xml
> > +++ b/docs/news.xml
> > @@ -88,6 +88,18 @@
> >             hotplugging PCI devices.
> >           </description>
> >         </change>
> > +      <change>
> > +        <summary>
> > +          Lease time option included for network DHCP settings
> > +        </summary>
> > +        <description>
> > +          Dnsmasq does not support to configure a global lease time. There
> > +          is no configuration option that could specify lease time. The
> > +          only way to configure lease time is setting it for each range's
> > +          and host's lines mainly. Libvirt now can configure lease time
> > +          for <code>range</code> and <code>host</code>.
> > +        </description>
> > +      </change>
> >       </section>
> >       <section title="Improvements">
> >       </section>
> >
>
> I don't think we need to document dnsmasq's limitations. How about simple:

Thinking that way... Yes... I agree.

>
> Users can now configure expiry time for leases for networks where
> libvirt manages DHCP. The time can be specified for whole range
> and/or fine tuned per individual host.
>
>
> Michal
>