[v2] setup: require python >= 3.5 to build

[libvirt-python PATCH v2] setup: require python >= 3.5 to build

Posted by Daniel P. Berrangé 5 years, 9 months ago

Pytjon 3.5 is the oldest Python version available across our supported
build platforms.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 setup.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/setup.py b/setup.py
index 56b6eea..39a07de 100755
--- a/setup.py
+++ b/setup.py
@@ -17,8 +17,8 @@ import re
 import shutil
 import time
 
-if sys.version_info[0] != 3:
-    print("libvirt-python requires Python 3.x to build")
+if sys.version_info < (3, 5):
+    print("libvirt-python requires Python >= 3.5 to build")
     sys.exit(1)
 
 MIN_LIBVIRT = "0.9.11"
@@ -368,5 +368,9 @@ of recent versions of Linux (and other OSes).''',
           "License :: OSI Approved :: GNU Lesser General Public License v2 or later (LGPLv2+)",
           "Programming Language :: Python",
           "Programming Language :: Python :: 3",
+          "Programming Language :: Python :: 3.5",
+          "Programming Language :: Python :: 3.6",
+          "Programming Language :: Python :: 3.7",
+          "Programming Language :: Python :: 3.8",
       ]
 )
-- 
2.25.2

Re: [libvirt-python PATCH v2] setup: require python >= 3.5 to build

Posted by Philipp Hahn 5 years, 9 months ago

Am 20.04.20 um 15:57 schrieb Daniel P. Berrangé:
> Pytjon 3.5 is the oldest Python version available across our supported
> build platforms.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Philipp Hahn <hahn@univention.de>

> ---
>  setup.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/setup.py b/setup.py
> index 56b6eea..39a07de 100755
> --- a/setup.py
> +++ b/setup.py
> @@ -17,8 +17,8 @@ import re
>  import shutil
>  import time
>  
> -if sys.version_info[0] != 3:
> -    print("libvirt-python requires Python 3.x to build")
> +if sys.version_info < (3, 5):
> +    print("libvirt-python requires Python >= 3.5 to build")
>      sys.exit(1)
>  
>  MIN_LIBVIRT = "0.9.11"
> @@ -368,5 +368,9 @@ of recent versions of Linux (and other OSes).''',
>            "License :: OSI Approved :: GNU Lesser General Public License v2 or later (LGPLv2+)",
>            "Programming Language :: Python",
>            "Programming Language :: Python :: 3",
> +          "Programming Language :: Python :: 3.5",
> +          "Programming Language :: Python :: 3.6",
> +          "Programming Language :: Python :: 3.7",
> +          "Programming Language :: Python :: 3.8",
>        ]
>  )
>

Re: [libvirt-python PATCH v2] setup: require python >= 3.5 to build

Posted by Daniel P. Berrangé 5 years, 9 months ago

On Tue, Apr 21, 2020 at 10:23:45PM +0200, Philipp Hahn wrote:
> Am 20.04.20 um 15:57 schrieb Daniel P. Berrangé:
> > Pytjon 3.5 is the oldest Python version available across our supported

I'll fix this typo before pushing

> > build platforms.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> 
> Reviewed-by: Philipp Hahn <hahn@univention.de>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|