[libvirt PATCH 00/10] vbox: update to support newer versions and drop eol versions

Daniel P. Berrangé posted 10 patches 4 years ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200417120135.326266-1-berrange@redhat.com
docs/news.xml                                 |    22 +
po/POTFILES.in                                |     1 -
src/vbox/Makefile.inc.am                      |    16 +-
.../{vbox_CAPI_v5_1.h => vbox_CAPI_v6_0.h}    | 14959 +++---
.../{vbox_CAPI_v5_0.h => vbox_CAPI_v6_1.h}    | 37642 +++++++++-------
src/vbox/vbox_MSCOMGlue.c                     |   779 -
src/vbox/vbox_MSCOMGlue.h                     |    45 -
src/vbox/{vbox_V5_0.c => vbox_V6_0.c}         |     6 +-
src/vbox/{vbox_V5_1.c => vbox_V6_1.c}         |     6 +-
src/vbox/vbox_XPCOMCGlue.h                    |     2 +-
src/vbox/vbox_common.h                        |    10 +-
src/vbox/vbox_driver.c                        |     2 +-
src/vbox/vbox_glue.c                          |    28 -
src/vbox/vbox_glue.h                          |    28 -
src/vbox/vbox_storage.c                       |    10 +-
src/vbox/vbox_tmpl.c                          |   104 +-
src/vbox/vbox_uniformed_api.h                 |     6 +-
17 files changed, 31851 insertions(+), 21815 deletions(-)
rename src/vbox/{vbox_CAPI_v5_1.h => vbox_CAPI_v6_0.h} (85%)
rename src/vbox/{vbox_CAPI_v5_0.h => vbox_CAPI_v6_1.h} (73%)
delete mode 100644 src/vbox/vbox_MSCOMGlue.c
delete mode 100644 src/vbox/vbox_MSCOMGlue.h
rename src/vbox/{vbox_V5_0.c => vbox_V6_0.c} (68%)
rename src/vbox/{vbox_V5_1.c => vbox_V6_1.c} (68%)
delete mode 100644 src/vbox/vbox_glue.c
delete mode 100644 src/vbox/vbox_glue.h
[libvirt PATCH 00/10] vbox: update to support newer versions and drop eol versions
Posted by Daniel P. Berrangé 4 years ago
This is the bare minimum patches required to let libvirt compile with
the latest virtualbox SDK for 6.0 and 6.1. Since I do not use
virtualbox this is compile tested only. This will at least give users
something to try and provide feedback on. In addition currently EOL
versions of virtualbox are dropped.

Daniel P. Berrangé (10):
  vbox: remove support for version 5.0 API
  vbox: remove version 5.0 CAPI header
  vbox: remove support for version 5.1 API
  vbox: remove version 5.1 CAPI header
  vbox: remove unused support for Windows MSCOM
  vbox: add version 6.0 CAPI header
  vbox: add support for version 6.0 SDK
  vbox: add version 6.1 CAPI header
  vbox: add support for version 6.1 SDK
  docs: add news about virtualbox version support changes

 docs/news.xml                                 |    22 +
 po/POTFILES.in                                |     1 -
 src/vbox/Makefile.inc.am                      |    16 +-
 .../{vbox_CAPI_v5_1.h => vbox_CAPI_v6_0.h}    | 14959 +++---
 .../{vbox_CAPI_v5_0.h => vbox_CAPI_v6_1.h}    | 37642 +++++++++-------
 src/vbox/vbox_MSCOMGlue.c                     |   779 -
 src/vbox/vbox_MSCOMGlue.h                     |    45 -
 src/vbox/{vbox_V5_0.c => vbox_V6_0.c}         |     6 +-
 src/vbox/{vbox_V5_1.c => vbox_V6_1.c}         |     6 +-
 src/vbox/vbox_XPCOMCGlue.h                    |     2 +-
 src/vbox/vbox_common.h                        |    10 +-
 src/vbox/vbox_driver.c                        |     2 +-
 src/vbox/vbox_glue.c                          |    28 -
 src/vbox/vbox_glue.h                          |    28 -
 src/vbox/vbox_storage.c                       |    10 +-
 src/vbox/vbox_tmpl.c                          |   104 +-
 src/vbox/vbox_uniformed_api.h                 |     6 +-
 17 files changed, 31851 insertions(+), 21815 deletions(-)
 rename src/vbox/{vbox_CAPI_v5_1.h => vbox_CAPI_v6_0.h} (85%)
 rename src/vbox/{vbox_CAPI_v5_0.h => vbox_CAPI_v6_1.h} (73%)
 delete mode 100644 src/vbox/vbox_MSCOMGlue.c
 delete mode 100644 src/vbox/vbox_MSCOMGlue.h
 rename src/vbox/{vbox_V5_0.c => vbox_V6_0.c} (68%)
 rename src/vbox/{vbox_V5_1.c => vbox_V6_1.c} (68%)
 delete mode 100644 src/vbox/vbox_glue.c
 delete mode 100644 src/vbox/vbox_glue.h

-- 
2.25.2


Re: [libvirt PATCH 00/10] vbox: update to support newer versions and drop eol versions
Posted by Michal Privoznik 3 years, 12 months ago
On 4/17/20 2:01 PM, Daniel P. Berrangé wrote:
> This is the bare minimum patches required to let libvirt compile with
> the latest virtualbox SDK for 6.0 and 6.1. Since I do not use
> virtualbox this is compile tested only. This will at least give users
> something to try and provide feedback on. In addition currently EOL
> versions of virtualbox are dropped.
> 
> Daniel P. Berrangé (10):
>    vbox: remove support for version 5.0 API
>    vbox: remove version 5.0 CAPI header
>    vbox: remove support for version 5.1 API
>    vbox: remove version 5.1 CAPI header
>    vbox: remove unused support for Windows MSCOM
>    vbox: add version 6.0 CAPI header
>    vbox: add support for version 6.0 SDK
>    vbox: add version 6.1 CAPI header
>    vbox: add support for version 6.1 SDK
>    docs: add news about virtualbox version support changes
> 
>   docs/news.xml                                 |    22 +
>   po/POTFILES.in                                |     1 -
>   src/vbox/Makefile.inc.am                      |    16 +-
>   .../{vbox_CAPI_v5_1.h => vbox_CAPI_v6_0.h}    | 14959 +++---
>   .../{vbox_CAPI_v5_0.h => vbox_CAPI_v6_1.h}    | 37642 +++++++++-------
>   src/vbox/vbox_MSCOMGlue.c                     |   779 -
>   src/vbox/vbox_MSCOMGlue.h                     |    45 -
>   src/vbox/{vbox_V5_0.c => vbox_V6_0.c}         |     6 +-
>   src/vbox/{vbox_V5_1.c => vbox_V6_1.c}         |     6 +-
>   src/vbox/vbox_XPCOMCGlue.h                    |     2 +-
>   src/vbox/vbox_common.h                        |    10 +-
>   src/vbox/vbox_driver.c                        |     2 +-
>   src/vbox/vbox_glue.c                          |    28 -
>   src/vbox/vbox_glue.h                          |    28 -
>   src/vbox/vbox_storage.c                       |    10 +-
>   src/vbox/vbox_tmpl.c                          |   104 +-
>   src/vbox/vbox_uniformed_api.h                 |     6 +-
>   17 files changed, 31851 insertions(+), 21815 deletions(-)
>   rename src/vbox/{vbox_CAPI_v5_1.h => vbox_CAPI_v6_0.h} (85%)
>   rename src/vbox/{vbox_CAPI_v5_0.h => vbox_CAPI_v6_1.h} (73%)
>   delete mode 100644 src/vbox/vbox_MSCOMGlue.c
>   delete mode 100644 src/vbox/vbox_MSCOMGlue.h
>   rename src/vbox/{vbox_V5_0.c => vbox_V6_0.c} (68%)
>   rename src/vbox/{vbox_V5_1.c => vbox_V6_1.c} (68%)
>   delete mode 100644 src/vbox/vbox_glue.c
>   delete mode 100644 src/vbox/vbox_glue.h
> 

Funny, I started working on this but never had gotten around sending it :-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal