docs: misc fixes to static asset handling

[libvirt PATCH 0/3] docs: misc fixes to static asset handling

Daniel P. Berrangé posted 3 patches 4 years ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200416115345.19810-1-berrange@redhat.com

docs/32favicon.png | Bin 783 -> 0 bytes
docs/Makefile.am   |  41 ++++++++++++++++++++++++-----------------
2 files changed, 24 insertions(+), 17 deletions(-)
delete mode 100644 docs/32favicon.png

Expand all Fold all

[libvirt PATCH 0/3] docs: misc fixes to static asset handling

Posted by Daniel P. Berrangé 4 years ago

When looking at switching libvirt.org to use files output from gitlab CI
I discovered some missing static assets

Daniel P. Berrangé (3):
  docs: fix handling of static assets in build dir
  docs: add missing files to static asset list
  docs: remove old unused favicon file

 docs/32favicon.png | Bin 783 -> 0 bytes
 docs/Makefile.am   |  41 ++++++++++++++++++++++++-----------------
 2 files changed, 24 insertions(+), 17 deletions(-)
 delete mode 100644 docs/32favicon.png

-- 
2.25.2

Re: [libvirt PATCH 0/3] docs: misc fixes to static asset handling

Posted by Laine Stump 4 years ago

On 4/16/20 7:53 AM, Daniel P. Berrangé wrote:
> When looking at switching libvirt.org to use files output from gitlab CI
> I discovered some missing static assets
>
> Daniel P. Berrangé (3):
>    docs: fix handling of static assets in build dir
>    docs: add missing files to static asset list
>    docs: remove old unused favicon file
>
>   docs/32favicon.png | Bin 783 -> 0 bytes
>   docs/Makefile.am   |  41 ++++++++++++++++++++++++-----------------
>   2 files changed, 24 insertions(+), 17 deletions(-)
>   delete mode 100644 docs/32favicon.png

It looks correct, and make rpm is successful on my system (after squashing in the bit you forgot), so


Reviewed-by: Laine Stump <laine@redhat.com>