[libvirt PATCH v2 8/9] gitlab: restrict git history to 100 commits

Daniel P. Berrangé posted 9 patches 5 years, 10 months ago
[libvirt PATCH v2 8/9] gitlab: restrict git history to 100 commits
Posted by Daniel P. Berrangé 5 years, 10 months ago
We don't need the full git history when running CI jobs. From a code POV
we only need the most recent commit, but we want to be able to run
checks on the commits too. In particular to validate the DCO signoff for
each commit.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 .gitlab-ci.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 9814b6580a..2286d28707 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -6,6 +6,7 @@ stages:
 
 variables:
   MAKE: make
+  GIT_DEPTH: 100
 
 
 # Common templates
-- 
2.24.1

Re: [libvirt PATCH v2 8/9] gitlab: restrict git history to 100 commits
Posted by Andrea Bolognani 5 years, 10 months ago
On Tue, 2020-03-24 at 16:24 +0000, Daniel P. Berrangé wrote:
> We don't need the full git history when running CI jobs. From a code POV
> we only need the most recent commit, but we want to be able to run
> checks on the commits too. In particular to validate the DCO signoff for
> each commit.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  .gitlab-ci.yml | 1 +
>  1 file changed, 1 insertion(+)

This would also make more sense right at the beginning of the series
instead of in the middle of it.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH v2 8/9] gitlab: restrict git history to 100 commits
Posted by Erik Skultety 5 years, 10 months ago
On Tue, Mar 24, 2020 at 06:48:52PM +0100, Andrea Bolognani wrote:
> On Tue, 2020-03-24 at 16:24 +0000, Daniel P. Berrangé wrote:
> > We don't need the full git history when running CI jobs. From a code POV
> > we only need the most recent commit, but we want to be able to run
> > checks on the commits too. In particular to validate the DCO signoff for
> > each commit.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  .gitlab-ci.yml | 1 +
> >  1 file changed, 1 insertion(+)
>
> This would also make more sense right at the beginning of the series
> instead of in the middle of it.
>
> Reviewed-by: Andrea Bolognani <abologna@redhat.com>

With Andrea's proposed change:
Reviewed-by: Erik Skultety <eskultet@redhat.com>