[PATCH 0/7] Move video default logic to individual drivers

Rafael Fonseca posted 7 patches 2 weeks ago
Test syntax-check failed
Failed in applying to current master (apply log)
src/bhyve/bhyve_domain.c   |  5 ++++
src/conf/domain_conf.c     | 52 +++------------------------------
src/conf/domain_conf.h     |  1 -
src/libvirt_private.syms   |  1 -
src/libxl/libxl_domain.c   | 60 +++++++++++++++++++++++---------------
src/openvz/openvz_conf.c   |  8 +++++
src/test/test_driver.c     | 23 +++++++++++++++
src/vbox/vbox_common.c     | 16 ++++++++++
src/vmware/vmware_driver.c |  4 +++
src/vmx/vmx.c              |  4 +++
src/vz/vz_driver.c         |  8 +++++
11 files changed, 108 insertions(+), 74 deletions(-)

[PATCH 0/7] Move video default logic to individual drivers

Posted by Rafael Fonseca 2 weeks ago
The logic setting a device default should be in the post parse function
of individual driver code, not in `src/conf/domain_conf.c`.

Rafael Fonseca (7):
  bhyve: move video default logic to driver
  libxl: move video default logic to driver
  vz: openvz: move video default logic to driver
  vmx: vmware: move video default logic to driver
  test: move video default logic to driver
  vbox: move video default logic to driver
  conf: domain_conf: remove virDomainVideoDefaultType

 src/bhyve/bhyve_domain.c   |  5 ++++
 src/conf/domain_conf.c     | 52 +++------------------------------
 src/conf/domain_conf.h     |  1 -
 src/libvirt_private.syms   |  1 -
 src/libxl/libxl_domain.c   | 60 +++++++++++++++++++++++---------------
 src/openvz/openvz_conf.c   |  8 +++++
 src/test/test_driver.c     | 23 +++++++++++++++
 src/vbox/vbox_common.c     | 16 ++++++++++
 src/vmware/vmware_driver.c |  4 +++
 src/vmx/vmx.c              |  4 +++
 src/vz/vz_driver.c         |  8 +++++
 11 files changed, 108 insertions(+), 74 deletions(-)

-- 
2.25.1


Re: [PATCH 0/7] Move video default logic to individual drivers

Posted by Michal Prívozník 2 weeks ago
On 24. 3. 2020 17:14, Rafael Fonseca wrote:
> The logic setting a device default should be in the post parse function
> of individual driver code, not in `src/conf/domain_conf.c`.
> 
> Rafael Fonseca (7):
>   bhyve: move video default logic to driver
>   libxl: move video default logic to driver
>   vz: openvz: move video default logic to driver
>   vmx: vmware: move video default logic to driver
>   test: move video default logic to driver
>   vbox: move video default logic to driver
>   conf: domain_conf: remove virDomainVideoDefaultType
> 
>  src/bhyve/bhyve_domain.c   |  5 ++++
>  src/conf/domain_conf.c     | 52 +++------------------------------
>  src/conf/domain_conf.h     |  1 -
>  src/libvirt_private.syms   |  1 -
>  src/libxl/libxl_domain.c   | 60 +++++++++++++++++++++++---------------
>  src/openvz/openvz_conf.c   |  8 +++++
>  src/test/test_driver.c     | 23 +++++++++++++++
>  src/vbox/vbox_common.c     | 16 ++++++++++
>  src/vmware/vmware_driver.c |  4 +++
>  src/vmx/vmx.c              |  4 +++
>  src/vz/vz_driver.c         |  8 +++++
>  11 files changed, 108 insertions(+), 74 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed. Nice cleanup.

Michal