[PATCH v2 0/2] vmx: make 'fileName' optional for CD-ROMs

Pino Toscano posted 2 patches 3 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200318095108.1444801-1-ptoscano@redhat.com
src/vmx/vmx.c                                 | 67 ++++++++++---------
.../vmx2xmldata/vmx2xml-cdrom-ide-empty-2.vmx |  4 ++
.../vmx2xmldata/vmx2xml-cdrom-ide-empty-2.xml | 23 +++++++
tests/vmx2xmltest.c                           |  1 +
4 files changed, 62 insertions(+), 33 deletions(-)
create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-empty-2.vmx
create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-empty-2.xml

[PATCH v2 0/2] vmx: make 'fileName' optional for CD-ROMs

Posted by Pino Toscano 3 weeks ago
v1 is:
https://www.redhat.com/archives/libvir-list/2020-March/msg00616.html

Changes from v1:
- added a patch to shortcut few checks
- use NULLSTR
- handle floppies (poor guys)

Pino Toscano (2):
  vmx: shortcut earlier few 'ignore' cases in virVMXParseDisk()
  vmx: make 'fileName' optional for CD-ROMs

 src/vmx/vmx.c                                 | 67 ++++++++++---------
 .../vmx2xmldata/vmx2xml-cdrom-ide-empty-2.vmx |  4 ++
 .../vmx2xmldata/vmx2xml-cdrom-ide-empty-2.xml | 23 +++++++
 tests/vmx2xmltest.c                           |  1 +
 4 files changed, 62 insertions(+), 33 deletions(-)
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-empty-2.vmx
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-empty-2.xml

-- 
2.25.1

Re: [PATCH v2 0/2] vmx: make 'fileName' optional for CD-ROMs

Posted by Richard W.M. Jones 3 weeks ago
Works, so:

Tested-by: Richard W.M. Jones <rjones@redhat.com>

I have no further comments about the patches themselves other than
what I said on the first version.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html

Re: [PATCH v2 0/2] vmx: make 'fileName' optional for CD-ROMs

Posted by Ján Tomko 3 weeks ago
On a Wednesday in 2020, Pino Toscano wrote:
>v1 is:
>https://www.redhat.com/archives/libvir-list/2020-March/msg00616.html
>
>Changes from v1:
>- added a patch to shortcut few checks
>- use NULLSTR
>- handle floppies (poor guys)
>
>Pino Toscano (2):
>  vmx: shortcut earlier few 'ignore' cases in virVMXParseDisk()
>  vmx: make 'fileName' optional for CD-ROMs
>
> src/vmx/vmx.c                                 | 67 ++++++++++---------
> .../vmx2xmldata/vmx2xml-cdrom-ide-empty-2.vmx |  4 ++
> .../vmx2xmldata/vmx2xml-cdrom-ide-empty-2.xml | 23 +++++++
> tests/vmx2xmltest.c                           |  1 +
> 4 files changed, 62 insertions(+), 33 deletions(-)
> create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-empty-2.vmx
> create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-empty-2.xml
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano