Ping
Also CC'ing Shiva since he implemented the QEMU side of this feature and
might be interested in it.
Shiva, mind tossing a review in patch 3/5? This is the one that contains
the alignment logic and I'd like to be certain that I didn't mess it up.
Thanks,
DHB
On 3/11/20 6:29 PM, Daniel Henrique Barboza wrote:
> changes in v2, all of them affecting just pSeries guests:
> - added 'label' requirement
> - added code to align down the NVDIMM device
> previous version: https://www.redhat.com/archives/libvir-list/2020-March/msg00165.html
>
> This patch series adds NVDIMM suport for ppc64 guests,
> which consists on adding an extra 'uuid' element in
> the nvdimm command line and the target label size must
> always be provided in the memory definition.
>
> No changes were made in the existing NVDIMM support for
> x86 and other archs.
>
>
> Daniel Henrique Barboza (5):
> conf: Introduce optional 'uuid' element for NVDIMM memory
> formatdomain.html.in: document the new 'uuid' NVDIMM element
> conf, qemu: enable NVDIMM support for ppc64
> formatdomain.html.in: document NVDIMM 'label' requirement for pSeries
> news.xml: document the new NVDIMM support for Pseries guests
>
> docs/formatdomain.html.in | 24 +++++++--
> docs/news.xml | 11 ++++
> docs/schemas/domaincommon.rng | 5 ++
> src/conf/domain_conf.c | 44 ++++++++++++++--
> src/conf/domain_conf.h | 3 ++
> src/qemu/qemu_command.c | 7 +++
> src/qemu/qemu_domain.c | 47 +++++++++++++++--
> .../memory-hotplug-nvdimm-ppc64.args | 32 ++++++++++++
> .../memory-hotplug-nvdimm-ppc64.xml | 50 +++++++++++++++++++
> tests/qemuxml2argvtest.c | 4 ++
> .../memory-hotplug-nvdimm-ppc64.xml | 50 +++++++++++++++++++
> tests/qemuxml2xmltest.c | 2 +
> 12 files changed, 268 insertions(+), 11 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.args
> create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.xml
> create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-ppc64.xml
>