v1:
https://www.redhat.com/archives/libvir-list/2020-February/msg00370.html

v2:
according to Dienial's suggestion:
* update each tls file one time -> update all of them at one time
* forced to re-create the credentials object, rather than allowing
  to append to the original ones.

Zhang Bo (5):
  virnetserver: Introduce virNetServerUpdateTlsFiles
  tls: Add a mutex lock on 'tlsCtxt'
  admin: Introduce virAdmServerUpdateTlsFiles
  virt-admin: Introduce command srv-update-tls
  docs: update virt-admin.rst for server-update-tls

 docs/manpages/virt-admin.rst         | 16 +++++++
 include/libvirt/libvirt-admin.h      |  3 ++
 src/admin/admin_protocol.x           | 12 +++++-
 src/admin/admin_server.c             |  9 ++++
 src/admin/admin_server.h             |  3 ++
 src/admin/libvirt-admin.c            | 30 +++++++++++++
 src/admin/libvirt_admin_private.syms |  1 +
 src/admin/libvirt_admin_public.syms  |  1 +
 src/libvirt_remote.syms              |  1 +
 src/rpc/virnetserver.c               | 51 ++++++++++++++++++++++
 src/rpc/virnetserver.h               |  2 +
 src/rpc/virnetserverclient.c         |  4 ++
 src/rpc/virnettlscontext.c           | 46 ++++++++++++++++++++
 src/rpc/virnettlscontext.h           |  3 ++
 tools/virt-admin.c                   | 64 ++++++++++++++++++++++++++++
 15 files changed, 245 insertions(+), 1 deletion(-)

-- 
2.23.0.windows.1

On Sat, Mar 07, 2020 at 07:30:59PM +0800, Zhang Bo wrote:
> v1:
> https://www.redhat.com/archives/libvir-list/2020-February/msg00370.html
> 
> v2:
> according to Dienial's suggestion:
> * update each tls file one time -> update all of them at one time
> * forced to re-create the credentials object, rather than allowing
>   to append to the original ones.

Aside from some minor mistakes this all looks fine code wise.

The commits, however, are missing the signed-off-by statement.
This is required to indicate that you agree to the contribution
policy at:

  https://developercertificate.org/

Assuming you're find with this, just reply to this mail with
a Signed-off-by: YOUR NAME <YOUR@EMAIL> and I'll add this to
the commit messages & push to git with the minor fixes.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Thank you, Daniel !
I appreciate that.

Signed-off-by: Zhang Bo <oscar.zhangbo@huawei.com>
Signed-off-by: Wu Qingliang <wuqingliang4@huawei.com>

> -----Original Message-----
> From: Daniel P. Berrangé [mailto:berrange@redhat.com]
> Sent: Thursday, March 12, 2020 12:22 AM
> To: Zhangbo (Oscar) <oscar.zhangbo@huawei.com>
> Cc: libvir-list@redhat.com; dengkai (A) <dengkai1@huawei.com>; wujing (O)
> <wujing42@huawei.com>; wuqingliang <wuqingliang4@huawei.com>
> Subject: Re: [PATCHv2 0/5] update tls files without restarting libvirtd
> 
> On Sat, Mar 07, 2020 at 07:30:59PM +0800, Zhang Bo wrote:
> > v1:
> > https://www.redhat.com/archives/libvir-list/2020-February/msg00370.htm
> > l
> >
> > v2:
> > according to Dienial's suggestion:
> > * update each tls file one time -> update all of them at one time
> > * forced to re-create the credentials object, rather than allowing
> >   to append to the original ones.
> 
> Aside from some minor mistakes this all looks fine code wise.
> 
> The commits, however, are missing the signed-off-by statement.
> This is required to indicate that you agree to the contribution policy at:
> 
>   https://developercertificate.org/
> 
> Assuming you're find with this, just reply to this mail with a Signed-off-by:
> YOUR NAME <YOUR@EMAIL> and I'll add this to the commit messages &
> push to git with the minor fixes.
> 
> Regards,
> Daniel
> --
> |: https://berrange.com      -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-
> https://www.instagram.com/dberrange :|