ci: Drop handling of $PKG_CONFIG_LIBDIR

[libvirt PATCH] ci: Drop handling of $PKG_CONFIG_LIBDIR

Andrea Bolognani posted 1 patch 4 years, 2 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200225145415.344749-1-abologna@redhat.com

ci/Makefile | 4 ----
1 file changed, 4 deletions(-)

Expand all Fold all

[libvirt PATCH] ci: Drop handling of $PKG_CONFIG_LIBDIR

Posted by Andrea Bolognani 4 years, 2 months ago

As of libvirt-jenkins-ci commit e41e341f0d8f, we no longer bake
this environment variable into our container images.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 ci/Makefile | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/ci/Makefile b/ci/Makefile
index 577b130d2f..bc1dac11e3 100644
--- a/ci/Makefile
+++ b/ci/Makefile
@@ -216,15 +216,11 @@ ci-run-command@%: ci-prepare-tree
 	$(CI_ENGINE) run $(CI_ENGINE_ARGS) $(CI_IMAGE_PREFIX)$*$(CI_IMAGE_TAG) \
 		/bin/bash -c ' \
 		$(CI_USER_HOME)/prepare || exit 1; \
-		if test "$$PKG_CONFIG_LIBDIR"; then \
-			pkgconfig_env="PKG_CONFIG_LIBDIR=$$PKG_CONFIG_LIBDIR"; \
-		fi; \
 		sudo \
 		  --login \
 		  --user="#$(CI_UID)" \
 		  --group="#$(CI_GID)" \
 		  CONFIGURE_OPTS="$$CONFIGURE_OPTS" \
-		  $$pkgconfig_env \
 		  CI_CONT_SRCDIR="$(CI_CONT_SRCDIR)" \
 		  CI_CONT_BUILDDIR="$(CI_CONT_BUILDDIR)" \
 		  CI_SMP="$(CI_SMP)" \
-- 
2.24.1

Re: [libvirt PATCH] ci: Drop handling of $PKG_CONFIG_LIBDIR

Posted by Ján Tomko 4 years, 1 month ago

On a Tuesday in 2020, Andrea Bolognani wrote:
>As of libvirt-jenkins-ci commit e41e341f0d8f, we no longer bake
>this environment variable into our container images.
>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
> ci/Makefile | 4 ----
> 1 file changed, 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano