support BR_ISOLATED flag for guest interfaces attached to a Linux host bridge

[libvirt PATCH 02/10] schema: add missing vlan element to networkport RNG

Posted by Laine Stump 5 years, 11 months ago

This is in the data structure and the parse/format functions, and is
getting passed all around correctly, it just was omitted from the RNG,
which hasn't been noticed because no human is creating <networkport>
XML, and so it's never getting validated against the schema.

Signed-off-by: Laine Stump <laine@redhat.com>
---
 docs/schemas/networkport.rng | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/docs/schemas/networkport.rng b/docs/schemas/networkport.rng
index 8cfc043a40..ea43c03d41 100644
--- a/docs/schemas/networkport.rng
+++ b/docs/schemas/networkport.rng
@@ -29,6 +29,9 @@
         <optional>
           <ref name="bandwidth"/>
         </optional>
+        <optional>
+          <ref name="vlan"/>
+        </optional>
         <optional>
           <ref name="plug"/>
         </optional>
-- 
2.24.1

Re: [libvirt PATCH 02/10] schema: add missing vlan element to networkport RNG

Posted by Ján Tomko 5 years, 11 months ago

On Sun, Feb 16, 2020 at 11:22:51PM -0500, Laine Stump wrote:
>This is in the data structure and the parse/format functions, and is
>getting passed all around correctly, it just was omitted from the RNG,
>which hasn't been noticed because no human is creating <networkport>
>XML, and so it's never getting validated against the schema.
>
>Signed-off-by: Laine Stump <laine@redhat.com>
>---
> docs/schemas/networkport.rng | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/docs/schemas/networkport.rng b/docs/schemas/networkport.rng

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano