[PATCH 5/5] ui: deprecate legacy -show-cursor option

Gerd Hoffmann posted 5 patches 6 years ago
There is a newer version of this series
[PATCH 5/5] ui: deprecate legacy -show-cursor option
Posted by Gerd Hoffmann 6 years ago
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 vl.c                 | 2 ++
 qemu-deprecated.texi | 5 +++++
 2 files changed, 7 insertions(+)

diff --git a/vl.c b/vl.c
index 0db0aa0fa040..71d040257b34 100644
--- a/vl.c
+++ b/vl.c
@@ -3552,6 +3552,8 @@ int main(int argc, char **argv, char **envp)
                 no_shutdown = 1;
                 break;
             case QEMU_OPTION_show_cursor:
+                warn_report("The -show-cursor option is deprecated, "
+                            "use -display {sdl,gtk},show-cursor=on instead");
                 dpy.has_show_cursor = true;
                 dpy.show_cursor = true;
                 break;
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 3d2a8ff54bae..ea4c5ca27f8e 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -148,6 +148,11 @@ QEMU 5.0 introduced an alternative syntax to specify the size of the translation
 block cache, @option{-accel tcg,tb-size=}.  The new syntax deprecates the
 previously available @option{-tb-size} option.
 
+@subsection -show-cursor option (since 5.0)
+
+Use @option{-display sdl,show-cursor=on} or
+ @option{-display gtk,show-cursor=on} instead.
+
 @section QEMU Machine Protocol (QMP) commands
 
 @subsection change (since 2.5.0)
-- 
2.18.1

Re: [PATCH 5/5] ui: deprecate legacy -show-cursor option
Posted by Ján Tomko 6 years ago
On Wed, Feb 05, 2020 at 12:03:56PM +0100, Gerd Hoffmann wrote:
>Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>---
> vl.c                 | 2 ++
> qemu-deprecated.texi | 5 +++++
> 2 files changed, 7 insertions(+)
>

libvirt does not use -show-cursor

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano