[libvirt PATCH 3/5] cpu: Add the kvm-no-adjvtime CPU feature

Andrea Bolognani posted 5 patches 6 years ago
[libvirt PATCH 3/5] cpu: Add the kvm-no-adjvtime CPU feature
Posted by Andrea Bolognani 6 years ago
The feature is currently available on ARM only, and so it only
needs to be known to the corresponding CPU driver.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/cpu_map/arm_features.xml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/cpu_map/arm_features.xml b/src/cpu_map/arm_features.xml
index 8a53384463..13d00f07a8 100644
--- a/src/cpu_map/arm_features.xml
+++ b/src/cpu_map/arm_features.xml
@@ -19,4 +19,7 @@
   <feature name='sve1920'/>
   <feature name='sve2048'/>
 
+  <!-- Other features -->
+  <feature name='kvm-no-adjvtime'/>
+
 </cpus>
-- 
2.24.1

Re: [libvirt PATCH 3/5] cpu: Add the kvm-no-adjvtime CPU feature
Posted by Ján Tomko 6 years ago
On Fri, Jan 31, 2020 at 05:39:50PM +0100, Andrea Bolognani wrote:
>The feature is currently available on ARM only, and so it only
>needs to be known to the corresponding CPU driver.
>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
> src/cpu_map/arm_features.xml | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/src/cpu_map/arm_features.xml b/src/cpu_map/arm_features.xml
>index 8a53384463..13d00f07a8 100644
>--- a/src/cpu_map/arm_features.xml
>+++ b/src/cpu_map/arm_features.xml
>@@ -19,4 +19,7 @@
>   <feature name='sve1920'/>
>   <feature name='sve2048'/>
>
>+  <!-- Other features -->
>+  <feature name='kvm-no-adjvtime'/>

I think just like other kvm* features, this would fit better
in the hypervisor features element, not the CPU driver.

Jano

>+
> </cpus>
>-- 
>2.24.1
>
Re: [libvirt PATCH 3/5] cpu: Add the kvm-no-adjvtime CPU feature
Posted by Andrea Bolognani 6 years ago
On Sun, 2020-02-02 at 14:40 +0100, Ján Tomko wrote:
> On Fri, Jan 31, 2020 at 05:39:50PM +0100, Andrea Bolognani wrote:
> > +  <!-- Other features -->
> > +  <feature name='kvm-no-adjvtime'/>
> 
> I think just like other kvm* features, this would fit better
> in the hypervisor features element, not the CPU driver.

You're right, it does sound like a better fit. I'll look into it.

-- 
Andrea Bolognani / Red Hat / Virtualization