[libvirt PATCH 1/5] tests: Add capabilities for QEMU 5.0.0 on aarch64

Andrea Bolognani posted 5 patches 6 years ago
[libvirt PATCH 1/5] tests: Add capabilities for QEMU 5.0.0 on aarch64
Posted by Andrea Bolognani 6 years ago
This is the first QEMU version that supports the kvm-no-adjvtime
CPU feature.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
This patch has been trimmed.

 .../qemu_5.0.0-virt.aarch64.xml               |   156 +
 tests/domaincapsdata/qemu_5.0.0.aarch64.xml   |   150 +
 .../caps_5.0.0.aarch64.replies                | 22717 ++++++++++++++++
 .../caps_5.0.0.aarch64.xml                    |   456 +
 4 files changed, 23479 insertions(+)
 create mode 100644 tests/domaincapsdata/qemu_5.0.0-virt.aarch64.xml
 create mode 100644 tests/domaincapsdata/qemu_5.0.0.aarch64.xml
 create mode 100644 tests/qemucapabilitiesdata/caps_5.0.0.aarch64.replies
 create mode 100644 tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml

diff --git a/tests/domaincapsdata/qemu_5.0.0-virt.aarch64.xml b/tests/domaincapsdata/qemu_5.0.0-virt.aarch64.xml
new file mode 100644
index 0000000000..f92ae951ca
--- /dev/null
+++ b/tests/domaincapsdata/qemu_5.0.0-virt.aarch64.xml
@@ -0,0 +1,156 @@
+<domainCapabilities>
+  <path>/usr/bin/qemu-system-aarch64</path>
+  <domain>kvm</domain>
+  <machine>virt-5.0</machine>
+  <arch>aarch64</arch>
[...]
diff --git a/tests/domaincapsdata/qemu_5.0.0.aarch64.xml b/tests/domaincapsdata/qemu_5.0.0.aarch64.xml
new file mode 100644
index 0000000000..232aacec2f
--- /dev/null
+++ b/tests/domaincapsdata/qemu_5.0.0.aarch64.xml
@@ -0,0 +1,150 @@
+<domainCapabilities>
+  <path>/usr/bin/qemu-system-aarch64</path>
+  <domain>kvm</domain>
+  <machine>integratorcp</machine>
+  <arch>aarch64</arch>
[...]
diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.replies b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.replies
new file mode 100644
index 0000000000..a3136a0966
--- /dev/null
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.replies
@@ -0,0 +1,22717 @@
+{
+  "execute": "qmp_capabilities",
+  "id": "libvirt-1"
+}
+
+{
+  "return": {
+  },
+  "id": "libvirt-1"
+}
+
+{
+  "execute": "query-version",
+  "id": "libvirt-2"
+}
+
+{
+  "return": {
+    "qemu": {
+      "micro": 50,
+      "minor": 2,
+      "major": 4
+    },
+    "package": "v4.2.0-1157-gadcd6e93b9"
+  },
+  "id": "libvirt-2"
+}
[...]
+{
+  "execute": "query-cpu-model-expansion",
+  "arguments": {
+    "type": "full",
+    "model": {
+      "name": "host"
+    }
+  },
+  "id": "libvirt-42"
+}
+
+{
+  "return": {
+    "model": {
+      "name": "host",
+      "props": {
+        "sve768": false,
+        "sve128": false,
+        "sve1024": false,
+        "sve1280": false,
+        "sve896": false,
+        "sve256": false,
+        "sve1536": false,
+        "sve1792": false,
+        "sve384": false,
+        "sve": false,
+        "sve2048": false,
+        "kvm-no-adjvtime": false,
+        "sve512": false,
+        "aarch64": true,
+        "pmu": true,
+        "sve1920": false,
+        "sve1152": false,
+        "sve640": false,
+        "sve1408": false,
+        "sve1664": false
+      }
+    }
+  },
+  "id": "libvirt-42"
+}
[...]
diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
new file mode 100644
index 0000000000..538b40dd5b
--- /dev/null
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
@@ -0,0 +1,456 @@
+<qemuCaps>
+  <emulator>/usr/bin/qemu-system-aarch64</emulator>
[...]
+  <version>4002050</version>
+  <kvmVersion>0</kvmVersion>
+  <microcodeVersion>61700241</microcodeVersion>
+  <package>v4.2.0-1157-gadcd6e93b9</package>
+  <arch>aarch64</arch>
+  <hostCPU type='kvm' model='host' migratability='no'>
+    <property name='sve768' type='boolean' value='false'/>
+    <property name='sve128' type='boolean' value='false'/>
+    <property name='sve1024' type='boolean' value='false'/>
+    <property name='sve1280' type='boolean' value='false'/>
+    <property name='sve896' type='boolean' value='false'/>
+    <property name='sve256' type='boolean' value='false'/>
+    <property name='sve1536' type='boolean' value='false'/>
+    <property name='sve1792' type='boolean' value='false'/>
+    <property name='sve384' type='boolean' value='false'/>
+    <property name='sve' type='boolean' value='false'/>
+    <property name='sve2048' type='boolean' value='false'/>
+    <property name='kvm-no-adjvtime' type='boolean' value='false'/>
+    <property name='sve512' type='boolean' value='false'/>
+    <property name='aarch64' type='boolean' value='true'/>
+    <property name='pmu' type='boolean' value='true'/>
+    <property name='sve1920' type='boolean' value='false'/>
+    <property name='sve1152' type='boolean' value='false'/>
+    <property name='sve640' type='boolean' value='false'/>
+    <property name='sve1408' type='boolean' value='false'/>
+    <property name='sve1664' type='boolean' value='false'/>
+  </hostCPU>
[...]
-- 
2.24.1

Re: [libvirt PATCH 1/5] tests: Add capabilities for QEMU 5.0.0 on aarch64
Posted by Ján Tomko 6 years ago
On Fri, Jan 31, 2020 at 05:39:48PM +0100, Andrea Bolognani wrote:
>This is the first QEMU version that supports the kvm-no-adjvtime
>CPU feature.

s/is/will be/
s/supports/will support/

>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>

FYI the sign-off is not present in the version you pushed to gitlab.

>---
>This patch has been trimmed.
>
> .../qemu_5.0.0-virt.aarch64.xml               |   156 +
> tests/domaincapsdata/qemu_5.0.0.aarch64.xml   |   150 +
> .../caps_5.0.0.aarch64.replies                | 22717 ++++++++++++++++
> .../caps_5.0.0.aarch64.xml                    |   456 +
> 4 files changed, 23479 insertions(+)
> create mode 100644 tests/domaincapsdata/qemu_5.0.0-virt.aarch64.xml
> create mode 100644 tests/domaincapsdata/qemu_5.0.0.aarch64.xml
> create mode 100644 tests/qemucapabilitiesdata/caps_5.0.0.aarch64.replies
> create mode 100644 tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
>
>diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
>new file mode 100644
>index 0000000000..538b40dd5b
>--- /dev/null
>+++ b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
>@@ -0,0 +1,456 @@
>+<qemuCaps>
>+  <emulator>/usr/bin/qemu-system-aarch64</emulator>
>[...]
>+  <version>4002050</version>
>+  <kvmVersion>0</kvmVersion>
>+  <microcodeVersion>61700241</microcodeVersion>
>+  <package>v4.2.0-1157-gadcd6e93b9</package>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

>+  <arch>aarch64</arch>
>+  <hostCPU type='kvm' model='host' migratability='no'>
>+    <property name='sve768' type='boolean' value='false'/>
>+    <property name='sve128' type='boolean' value='false'/>
Re: [libvirt PATCH 1/5] tests: Add capabilities for QEMU 5.0.0 on aarch64
Posted by Andrea Bolognani 6 years ago
On Sun, 2020-02-02 at 14:25 +0100, Ján Tomko wrote:
> On Fri, Jan 31, 2020 at 05:39:48PM +0100, Andrea Bolognani wrote:
> > This is the first QEMU version that supports the kvm-no-adjvtime
> > CPU feature.
> 
> s/is/will be/
> s/supports/will support/
> 
> > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> 
> FYI the sign-off is not present in the version you pushed to gitlab.

I have no signed-offs locally, and let git-publish add them at the
time I post patches. It's a nice failsafe in case I type the wrong
git push incantation by mistake :)

> Reviewed-by: Ján Tomko <jtomko@redhat.com>

Thanks, I'll fix the commit message and push this one patch for the
moment.

-- 
Andrea Bolognani / Red Hat / Virtualization