[libvirt PATCH v2 49/56] tools: conditionalize use of O_SYNC flag

Daniel P. Berrangé posted 56 patches 6 years ago
There is a newer version of this series
[libvirt PATCH v2 49/56] tools: conditionalize use of O_SYNC flag
Posted by Daniel P. Berrangé 6 years ago
The O_SYNC flag is not defined on Windows platforms.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tools/vsh.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/vsh.c b/tools/vsh.c
index 2cf3dab054..cd473ef1d6 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -2152,7 +2152,11 @@ vshEventCleanup(vshControl *ctl)
     virEventUpdateTimeout(ctl->eventTimerId, -1);
 }
 
-#define LOGFILE_FLAGS (O_WRONLY | O_APPEND | O_CREAT | O_SYNC)
+#ifdef O_SYNC
+# define LOGFILE_FLAGS (O_WRONLY | O_APPEND | O_CREAT | O_SYNC)
+#else
+# define LOGFILE_FLAGS (O_WRONLY | O_APPEND | O_CREAT)
+#endif
 
 /**
  * vshOpenLogFile:
-- 
2.24.1

Re: [libvirt PATCH v2 49/56] tools: conditionalize use of O_SYNC flag
Posted by Pavel Hrdina 6 years ago
On Tue, Jan 28, 2020 at 01:11:30PM +0000, Daniel P. Berrangé wrote:
> The O_SYNC flag is not defined on Windows platforms.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  tools/vsh.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>