[PATCH 0/2] lxc: Implement lxcDomainInterfaceAddresses() function

Julio Faracco posted 2 patches 4 years, 3 months ago
Test syntax-check failed
Failed in applying to current master (apply log)
src/conf/domain_conf.c   | 134 ++++++++++++++++++++++++++++++++++++++
src/conf/domain_conf.h   |   2 +
src/libvirt_private.syms |   2 +
src/lxc/lxc_driver.c     |  44 +++++++++++++
src/qemu/qemu_driver.c   | 137 +--------------------------------------
5 files changed, 184 insertions(+), 135 deletions(-)
[PATCH 0/2] lxc: Implement lxcDomainInterfaceAddresses() function
Posted by Julio Faracco 4 years, 3 months ago
It is not able to retrieve IP addresses from LXC domains. This method
was not implemented before. LXC uses the same operations to retrieve
this information, but QEMU has their own functions to process this data.
This series turn them into global functions, moving them into domain
conf methods, to make them available for other drivers. The only source
that LXC does not support is agent which is a specific source from QEMU.

Julio Faracco (2):
  qemu: Converting DHCP and ARP functions to domain conf
  lxc: Add support to lxcDomainInterfaceAddresses() function

 src/conf/domain_conf.c   | 134 ++++++++++++++++++++++++++++++++++++++
 src/conf/domain_conf.h   |   2 +
 src/libvirt_private.syms |   2 +
 src/lxc/lxc_driver.c     |  44 +++++++++++++
 src/qemu/qemu_driver.c   | 137 +--------------------------------------
 5 files changed, 184 insertions(+), 135 deletions(-)

-- 
2.20.1


Re: [PATCH 0/2] lxc: Implement lxcDomainInterfaceAddresses() function
Posted by Michal Privoznik 4 years, 3 months ago
On 1/21/20 4:37 AM, Julio Faracco wrote:
> It is not able to retrieve IP addresses from LXC domains. This method
> was not implemented before. LXC uses the same operations to retrieve
> this information, but QEMU has their own functions to process this data.
> This series turn them into global functions, moving them into domain
> conf methods, to make them available for other drivers. The only source
> that LXC does not support is agent which is a specific source from QEMU.
> 
> Julio Faracco (2):
>    qemu: Converting DHCP and ARP functions to domain conf
>    lxc: Add support to lxcDomainInterfaceAddresses() function
> 
>   src/conf/domain_conf.c   | 134 ++++++++++++++++++++++++++++++++++++++
>   src/conf/domain_conf.h   |   2 +
>   src/libvirt_private.syms |   2 +
>   src/lxc/lxc_driver.c     |  44 +++++++++++++
>   src/qemu/qemu_driver.c   | 137 +--------------------------------------
>   5 files changed, 184 insertions(+), 135 deletions(-)
> 


Fixed, and pushed.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal