[libvirt PATCH 03/12] conf: rename two static functions

Laine Stump posted 12 patches 6 years ago
[libvirt PATCH 03/12] conf: rename two static functions
Posted by Laine Stump 6 years ago
Adding Driver to the names makes them better fit their purpose.

Signed-off-by: Laine Stump <laine@redhat.com>
---
 src/conf/domain_conf.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 69e3b7be9a..58f4a1c14b 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -25318,8 +25318,8 @@ virDomainActualNetDefFormat(virBufferPtr buf,
 
 
 static void
-virDomainVirtioNetGuestOptsFormat(char **outstr,
-                                  virDomainNetDefPtr def)
+virDomainVirtioNetDriverGuestOptsFormat(char **outstr,
+                                        virDomainNetDefPtr def)
 {
     virBuffer buf = VIR_BUFFER_INITIALIZER;
     if (def->driver.virtio.guest.csum) {
@@ -25349,8 +25349,8 @@ virDomainVirtioNetGuestOptsFormat(char **outstr,
 
 
 static void
-virDomainVirtioNetHostOptsFormat(char **outstr,
-                                 virDomainNetDefPtr def)
+virDomainVirtioNetDriverHostOptsFormat(char **outstr,
+                                       virDomainNetDefPtr def)
 {
     virBuffer buf = VIR_BUFFER_INITIALIZER;
     if (def->driver.virtio.host.csum) {
@@ -25698,8 +25698,8 @@ virDomainNetDefFormat(virBufferPtr buf,
             g_autofree char *hoststr = NULL;
 
             virDomainVirtioNetDriverFormat(&str, def);
-            virDomainVirtioNetGuestOptsFormat(&gueststr, def);
-            virDomainVirtioNetHostOptsFormat(&hoststr, def);
+            virDomainVirtioNetDriverGuestOptsFormat(&gueststr, def);
+            virDomainVirtioNetDriverHostOptsFormat(&hoststr, def);
 
             if (!gueststr && !hoststr) {
                 if (str)
-- 
2.24.1

Re: [libvirt PATCH 03/12] conf: rename two static functions
Posted by Daniel P. Berrangé 6 years ago
On Sun, Jan 19, 2020 at 10:24:10PM -0500, Laine Stump wrote:
> Adding Driver to the names makes them better fit their purpose.
> 
> Signed-off-by: Laine Stump <laine@redhat.com>
> ---
>  src/conf/domain_conf.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|