[libvirt PATCH] gitpublish: add a subject prefix

Daniel P. Berrangé posted 1 patch 4 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200116123620.6119-1-berrange@redhat.com
.gitpublish | 1 +
1 file changed, 1 insertion(+)
[libvirt PATCH] gitpublish: add a subject prefix
Posted by Daniel P. Berrangé 4 years, 3 months ago
Now that we removed the subject prefix tag from the mailman config
we should set 'libvirt' as the subject when sending patches.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 .gitpublish | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitpublish b/.gitpublish
index 857f0d552c..d37bf4174a 100644
--- a/.gitpublish
+++ b/.gitpublish
@@ -1,3 +1,4 @@
 [gitpublishprofile "default"]
 base = master
 to = libvir-list@redhat.com
+prefix = libvirt PATCH
-- 
2.23.0

Re: [libvirt PATCH] gitpublish: add a subject prefix
Posted by Daniel P. Berrangé 4 years, 3 months ago
On Thu, Jan 16, 2020 at 12:36:20PM +0000, Daniel P. Berrangé wrote:
> Now that we removed the subject prefix tag from the mailman config
> we should set 'libvirt' as the subject when sending patches.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  .gitpublish | 1 +
>  1 file changed, 1 insertion(+)

We should do likewise for all other GIT repos. I'm assuming
people don't want to review another 15 patches changing
this, so please just ack the following change, applied
to every other repo with the obvious subsitutions:

diff --git a/.gitpublish b/.gitpublish
index 2fe1539..dced716 100644
--- a/.gitpublish
+++ b/.gitpublish
@@ -1,4 +1,4 @@
 [gitpublishprofile "default"]
 base = master
 to = libvir-list@redhat.com
-prefix = python PATCH
+prefix = libvirt-python PATCH

> 
> diff --git a/.gitpublish b/.gitpublish
> index 857f0d552c..d37bf4174a 100644
> --- a/.gitpublish
> +++ b/.gitpublish
> @@ -1,3 +1,4 @@
>  [gitpublishprofile "default"]
>  base = master
>  to = libvir-list@redhat.com
> +prefix = libvirt PATCH
> -- 
> 2.23.0
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [libvirt PATCH] gitpublish: add a subject prefix
Posted by Ján Tomko 4 years, 3 months ago
On Thu, Jan 16, 2020 at 12:38:07PM +0000, Daniel P. Berrangé wrote:
>On Thu, Jan 16, 2020 at 12:36:20PM +0000, Daniel P. Berrangé wrote:
>> Now that we removed the subject prefix tag from the mailman config
>> we should set 'libvirt' as the subject when sending patches.
>>
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>>  .gitpublish | 1 +
>>  1 file changed, 1 insertion(+)
>
>We should do likewise for all other GIT repos. I'm assuming
>people don't want to review another 15 patches changing
>this, so please just ack the following change, applied
>to every other repo with the obvious subsitutions:
>
>diff --git a/.gitpublish b/.gitpublish
>index 2fe1539..dced716 100644
>--- a/.gitpublish
>+++ b/.gitpublish
>@@ -1,4 +1,4 @@
> [gitpublishprofile "default"]
> base = master
> to = libvir-list@redhat.com
>-prefix = python PATCH
>+prefix = libvirt-python PATCH

Reviewed-by: Ján Tomko <jtomko@redhat.com>

This looks nicer than 'libvirt] [python PATCH'

>
>>
>> diff --git a/.gitpublish b/.gitpublish
>> index 857f0d552c..d37bf4174a 100644
>> --- a/.gitpublish
>> +++ b/.gitpublish
>> @@ -1,3 +1,4 @@
>>  [gitpublishprofile "default"]
>>  base = master
>>  to = libvir-list@redhat.com
>> +prefix = libvirt PATCH

I have been using an explicit [libvirt] [PATCH] prefix before, but
stopped after mailman started inserting a random number of spaces
between the brackets.

Jano

>> --
>> 2.23.0
>>
>
>Regards,
>Daniel
>-- 
>|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
>|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
>|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>