[libvirt] [PATCH] man: fix section of virt-sanlock-cleanup

Christian Ehrhardt posted 1 patch 4 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200116104212.14416-1-christian.ehrhardt@canonical.com
docs/manpages/virt-sanlock-cleanup.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] man: fix section of virt-sanlock-cleanup
Posted by Christian Ehrhardt 4 years, 3 months ago
Reported at buld time by litian:
manpage-section-mismatch usr/share/man/man8/virt-sanlock-cleanup.8.gz:3 8 != 1

And indeed the rst file says 1 while the makefile say 8:
 if WITH_SANLOCK
   manpages8_rst += manpages/virt-sanlock-cleanup.rst
 else ! WITH_SANLOCK

8 "System administration commands and daemons" seems to match, so fix
the rst file to match.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 docs/manpages/virt-sanlock-cleanup.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/manpages/virt-sanlock-cleanup.rst b/docs/manpages/virt-sanlock-cleanup.rst
index ac49fa4191..3ad70ce683 100644
--- a/docs/manpages/virt-sanlock-cleanup.rst
+++ b/docs/manpages/virt-sanlock-cleanup.rst
@@ -6,7 +6,7 @@ virt-sanlock-cleanup
 remove stale sanlock resource lease files
 -----------------------------------------
 
-:Manual section: 1
+:Manual section: 8
 :Manual group: Virtualization Support
 
 .. contents::
-- 
2.25.0


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] man: fix section of virt-sanlock-cleanup
Posted by Daniel Henrique Barboza 4 years, 3 months ago

On 1/16/20 7:42 AM, Christian Ehrhardt wrote:
> Reported at buld time by litian:

s/buld/build



> manpage-section-mismatch usr/share/man/man8/virt-sanlock-cleanup.8.gz:3 8 != 1
> 
> And indeed the rst file says 1 while the makefile say 8:
>   if WITH_SANLOCK
>     manpages8_rst += manpages/virt-sanlock-cleanup.rst
>   else ! WITH_SANLOCK
> 
> 8 "System administration commands and daemons" seems to match, so fix
> the rst file to match.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Re: [libvirt] [PATCH] man: fix section of virt-sanlock-cleanup
Posted by Andrea Bolognani 4 years, 3 months ago
On Thu, 2020-01-16 at 10:37 -0300, Daniel Henrique Barboza wrote:
> On 1/16/20 7:42 AM, Christian Ehrhardt wrote:
> > Reported at buld time by litian:
> 
> s/buld/build

Also s/litian/lintian/ ;)

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

and pushed.

-- 
Andrea Bolognani / Red Hat / Virtualization