[v2] fix segfaults on qemuhotplugtest

[libvirt] [PATCH v2 0/2] fix segfaults on qemuhotplugtest

Christian Ehrhardt posted 2 patches 4 years, 3 months ago

Diff against v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200116082856.4040-1-christian.ehrhardt@canonical.com

tests/qemuhotplugmock.c | 17 +++++++++++++++++
tests/qemuhotplugtest.c |  5 +++++
2 files changed, 22 insertions(+)

Expand all Fold all

[libvirt] [PATCH v2 0/2] fix segfaults on qemuhotplugtest

Posted by Christian Ehrhardt 4 years, 3 months ago

After debugging for a while and eventually finding the root cause we
discussed this on IRC today:

<cpaelzer> danpb: BTW the test crash in 6.0 that I'm tracing (asked yesterday)
           is virHostdevManagerInitialize failing
<cpaelzer> the test goes on with mgr set to 0x0 and that is the segfault
           later on
<cpaelzer> virSetError was helpful as "Could not initialize HostdevManager
           operation failed: Failed to create state dir
           '/sbuild-nonexistent/.cache/libvirt/hostdevmgr'" sounds like a
           very testbed-specific issue that I might be able to solve when
           invoking the tests
<danpb> hmm, seems like we're missing a mock for  mkdir()
<danpb> i guess we should mock  virFileMakePath in this case

This series got v6.0.0 building in Ubuntu, so I thought it is worth to
submit it for review.

Updates in v2:
- improve indent of virGetLastErrorMessage
- drop superfluous curly brackets
- added the Reviewed-by of Daniel Henrique Barboza (Thanks !)

Christian Ehrhardt (2):
  test: let qemuhotplugtest report details of init fails
  test: qemuhotplugtest mock virFileMakePath

 tests/qemuhotplugmock.c | 17 +++++++++++++++++
 tests/qemuhotplugtest.c |  5 +++++
 2 files changed, 22 insertions(+)

-- 
2.25.0


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list