[libvirt] [PATCH] gnulib: Pull in latest changes

Andrea Bolognani posted 1 patch 29 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200114172133.583314-1-abologna@redhat.com
.gnulib | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH] gnulib: Pull in latest changes

Posted by Andrea Bolognani 29 weeks ago
In particular, we're interested in the following commits:

  commit 43b5194d5b156f8dd7ae576952568d331978f5f0
  Author: Bruno Haible <bruno@clisp.org>
  Date:   Sun Jan 5 20:42:12 2020 +0100

    tests: Avoid GCC over-optimization caused by _GL_ARG_NONNULL attributes.

    * lib/stdlib.in.h: Tweak last commit.

  commit b7d7afe10ddf599452bd80b8a840c830cd474b09
  Author: Bruno Haible <bruno@clisp.org>
  Date:   Sun Jan 5 09:13:25 2020 +0100

    tests: Avoid GCC over-optimization caused by _GL_ARG_NONNULL attributes.

    Reported by Jim Meyering in
    <https://lists.gnu.org/archive/html/bug-gnulib/2020-01/msg00040.html>.

    * lib/stdlib.in.h (GNULIB_defined_canonicalize_file_name): New macro.
    (GNULIB_defined_ptsname_r): New macro.
    * tests/test-canonicalize.c (_GL_ARG_NONNULL): Define to empty.
    (main): Disable the NULL argument test if canonicalize_file_name does
    not come from gnulib.
    * tests/test-canonicalize-lgpl.c (_GL_ARG_NONNULL): Define to empty.
    (main): Disable the NULL argument test if canonicalize_file_name does
    not come from gnulib.
    * tests/test-ptsname_r.c (_GL_ARG_NONNULL): Define to empty.
    (test_errors): Disable the NULL argument test if ptsname_r does not come
    from gnulib.

since they fix a build failure caused by the gnulib tests failing
on ppc64le, as reported in

  https://www.redhat.com/archives/libvir-list/2020-January/msg00616.html

Reported-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Tracked-down-by: Bruno Haible <bruno@clisp.org>
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
Note that I have not actually had the time to confirm this fixes
the problem, or to reproduce it in the first place (I'll do that
tomorrow). Either way, it's waaaaay too late for this to make it
into v6.0.0; I'm mostly posting this so that the reporter can
have a go at testing it in the meantime.

 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index 7d06937892..611869be9f 160000
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 7d069378921bfa0d7c7198ea177aac0a2440016f
+Subproject commit 611869be9f1083e53305446d90a2909fc89914ef
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] gnulib: Pull in latest changes

Posted by Satheesh Rajendran 29 weeks ago
On Tue, Jan 14, 2020 at 06:21:33PM +0100, Andrea Bolognani wrote:
> In particular, we're interested in the following commits:
> 
>   commit 43b5194d5b156f8dd7ae576952568d331978f5f0
>   Author: Bruno Haible <bruno@clisp.org>
>   Date:   Sun Jan 5 20:42:12 2020 +0100
> 
>     tests: Avoid GCC over-optimization caused by _GL_ARG_NONNULL attributes.
> 
>     * lib/stdlib.in.h: Tweak last commit.
> 
>   commit b7d7afe10ddf599452bd80b8a840c830cd474b09
>   Author: Bruno Haible <bruno@clisp.org>
>   Date:   Sun Jan 5 09:13:25 2020 +0100
> 
>     tests: Avoid GCC over-optimization caused by _GL_ARG_NONNULL attributes.
> 
>     Reported by Jim Meyering in
>     <https://lists.gnu.org/archive/html/bug-gnulib/2020-01/msg00040.html>.
> 
>     * lib/stdlib.in.h (GNULIB_defined_canonicalize_file_name): New macro.
>     (GNULIB_defined_ptsname_r): New macro.
>     * tests/test-canonicalize.c (_GL_ARG_NONNULL): Define to empty.
>     (main): Disable the NULL argument test if canonicalize_file_name does
>     not come from gnulib.
>     * tests/test-canonicalize-lgpl.c (_GL_ARG_NONNULL): Define to empty.
>     (main): Disable the NULL argument test if canonicalize_file_name does
>     not come from gnulib.
>     * tests/test-ptsname_r.c (_GL_ARG_NONNULL): Define to empty.
>     (test_errors): Disable the NULL argument test if ptsname_r does not come
>     from gnulib.
> 
> since they fix a build failure caused by the gnulib tests failing
> on ppc64le, as reported in
> 
>   https://www.redhat.com/archives/libvir-list/2020-January/msg00616.html
> 
> Reported-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>

Tested and build is working fine with these commit.

Regards,
-Satheesh

> Tracked-down-by: Bruno Haible <bruno@clisp.org>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
> Note that I have not actually had the time to confirm this fixes
> the problem, or to reproduce it in the first place (I'll do that
> tomorrow). Either way, it's waaaaay too late for this to make it
> into v6.0.0; I'm mostly posting this so that the reporter can
> have a go at testing it in the meantime.
> 
>  .gnulib | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gnulib b/.gnulib
> index 7d06937892..611869be9f 160000
> --- a/.gnulib
> +++ b/.gnulib
> @@ -1 +1 @@
> -Subproject commit 7d069378921bfa0d7c7198ea177aac0a2440016f
> +Subproject commit 611869be9f1083e53305446d90a2909fc89914ef
> -- 
> 2.24.1
> 


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] gnulib: Pull in latest changes

Posted by Andrea Bolognani 29 weeks ago
On Tue, 2020-01-14 at 18:21 +0100, Andrea Bolognani wrote:
> Note that I have not actually had the time to confirm this fixes
> the problem, or to reproduce it in the first place (I'll do that
> tomorrow).

I haven't been able to reproduce the issue in a fully up to date
Fedora 31 ppc64le guest, so obviously I can't confirm updating gnulib
actually addresses it.

Either way, I'll push this under the gnulib update rule once 6.1.0 is
open for business.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list