domain_addr and qemu_domain cleanups

[libvirt] [PATCH v1 0/8] domain_addr and qemu_domain cleanups

Posted by Daniel Henrique Barboza 4 years, 3 months ago

Hi,

These are a few cleanups in some files that I'll end up
messing with in a future series (which isn't Glibfied ATM).
Figured it's best to clean them up now instead of adding
more non-Glibfied code on top.

Patches 7 and 8 are stuff that I noted some time ago and
figured it might be worth sending as well.


Daniel Henrique Barboza (8):
  conf/domain_addr.c: use g_autofree in strings
  conf/domain_addr.c: remove unneeded 'cleanup' labels
  qemu_domain.c: remove redundant virObjectUnref()
  qemu_domain.c: use g_autofree when possible
  qemu_domain.c: use g_autoptr when possible
  qemu_domain.c: removing unneeded cleanup labels
  qemu_domain.c: turn qemuDomainChrDefDropDefaultPath to void
  qemu_domain_address.c: turn qemuDomainFillDeviceIsolationGroup to void

 src/conf/domain_addr.c         | 124 +++-----
 src/qemu/qemu_domain.c         | 511 +++++++++++----------------------
 src/qemu/qemu_domain_address.c |  20 +-
 src/qemu/qemu_domain_address.h |   2 +-
 src/qemu/qemu_hotplug.c        |   6 +-
 5 files changed, 227 insertions(+), 436 deletions(-)

-- 
2.24.1


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [PATCH v1 0/8] domain_addr and qemu_domain cleanups

Posted by Daniel Henrique Barboza 4 years, 3 months ago

Ping

On 1/9/20 3:33 PM, Daniel Henrique Barboza wrote:
> Hi,
> 
> These are a few cleanups in some files that I'll end up
> messing with in a future series (which isn't Glibfied ATM).
> Figured it's best to clean them up now instead of adding
> more non-Glibfied code on top.
> 
> Patches 7 and 8 are stuff that I noted some time ago and
> figured it might be worth sending as well.
> 
> 
> Daniel Henrique Barboza (8):
>    conf/domain_addr.c: use g_autofree in strings
>    conf/domain_addr.c: remove unneeded 'cleanup' labels
>    qemu_domain.c: remove redundant virObjectUnref()
>    qemu_domain.c: use g_autofree when possible
>    qemu_domain.c: use g_autoptr when possible
>    qemu_domain.c: removing unneeded cleanup labels
>    qemu_domain.c: turn qemuDomainChrDefDropDefaultPath to void
>    qemu_domain_address.c: turn qemuDomainFillDeviceIsolationGroup to void
> 
>   src/conf/domain_addr.c         | 124 +++-----
>   src/qemu/qemu_domain.c         | 511 +++++++++++----------------------
>   src/qemu/qemu_domain_address.c |  20 +-
>   src/qemu/qemu_domain_address.h |   2 +-
>   src/qemu/qemu_hotplug.c        |   6 +-
>   5 files changed, 227 insertions(+), 436 deletions(-)
>

Re: [libvirt] [PATCH v1 0/8] domain_addr and qemu_domain cleanups

Posted by Michal Privoznik 4 years, 2 months ago

On 1/9/20 7:33 PM, Daniel Henrique Barboza wrote:
> Hi,
> 
> These are a few cleanups in some files that I'll end up
> messing with in a future series (which isn't Glibfied ATM).
> Figured it's best to clean them up now instead of adding
> more non-Glibfied code on top.
> 
> Patches 7 and 8 are stuff that I noted some time ago and
> figured it might be worth sending as well.
> 
> 
> Daniel Henrique Barboza (8):
>    conf/domain_addr.c: use g_autofree in strings
>    conf/domain_addr.c: remove unneeded 'cleanup' labels
>    qemu_domain.c: remove redundant virObjectUnref()
>    qemu_domain.c: use g_autofree when possible
>    qemu_domain.c: use g_autoptr when possible
>    qemu_domain.c: removing unneeded cleanup labels
>    qemu_domain.c: turn qemuDomainChrDefDropDefaultPath to void
>    qemu_domain_address.c: turn qemuDomainFillDeviceIsolationGroup to void
> 
>   src/conf/domain_addr.c         | 124 +++-----
>   src/qemu/qemu_domain.c         | 511 +++++++++++----------------------
>   src/qemu/qemu_domain_address.c |  20 +-
>   src/qemu/qemu_domain_address.h |   2 +-
>   src/qemu/qemu_hotplug.c        |   6 +-
>   5 files changed, 227 insertions(+), 436 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com> and pushed. Sorry 
for the delay.

Michal