[libvirt] [jenkins-ci PATCH] jenkins: recursively update submodules on checkout

Daniel P. Berrangé posted 1 patch 2 weeks ago
Failed in applying to current master (apply log)
jenkins/jobs/autotools.yaml        | 2 ++
jenkins/jobs/generic.yaml          | 2 ++
jenkins/jobs/go.yaml               | 2 ++
jenkins/jobs/meson.yaml            | 2 ++
jenkins/jobs/perl-modulebuild.yaml | 2 ++
jenkins/jobs/python-distutils.yaml | 2 ++
6 files changed, 12 insertions(+)

[libvirt] [jenkins-ci PATCH] jenkins: recursively update submodules on checkout

Posted by Daniel P. Berrangé 2 weeks ago
The ansible playback runs 'git submodule update --init', so we
should have jenkins do the equivalent to ensure consistent
build environment setup.

In particular this works arounda bug with Meson when using
GIT on CentOS 7, causing it to fail to automatically update
the submodules.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 jenkins/jobs/autotools.yaml        | 2 ++
 jenkins/jobs/generic.yaml          | 2 ++
 jenkins/jobs/go.yaml               | 2 ++
 jenkins/jobs/meson.yaml            | 2 ++
 jenkins/jobs/perl-modulebuild.yaml | 2 ++
 jenkins/jobs/python-distutils.yaml | 2 ++
 6 files changed, 12 insertions(+)

diff --git a/jenkins/jobs/autotools.yaml b/jenkins/jobs/autotools.yaml
index 413af73..6b4d3f8 100644
--- a/jenkins/jobs/autotools.yaml
+++ b/jenkins/jobs/autotools.yaml
@@ -27,6 +27,8 @@
             after: true
           skip-tag: true
           wipe-workspace: false
+          submodule:
+            recursive: true
     triggers:
       - reverse:
           jobs: '{obj:parent_jobs}'
diff --git a/jenkins/jobs/generic.yaml b/jenkins/jobs/generic.yaml
index ca69513..46425ec 100644
--- a/jenkins/jobs/generic.yaml
+++ b/jenkins/jobs/generic.yaml
@@ -27,6 +27,8 @@
             after: true
           skip-tag: true
           wipe-workspace: false
+          submodule:
+            recursive: true
     triggers:
       - reverse:
           jobs: '{obj:parent_jobs}'
diff --git a/jenkins/jobs/go.yaml b/jenkins/jobs/go.yaml
index 1bdcb5f..3d25493 100644
--- a/jenkins/jobs/go.yaml
+++ b/jenkins/jobs/go.yaml
@@ -27,6 +27,8 @@
             after: true
           skip-tag: true
           wipe-workspace: false
+          submodule:
+            recursive: true
     triggers:
       - reverse:
           jobs: '{obj:parent_jobs}'
diff --git a/jenkins/jobs/meson.yaml b/jenkins/jobs/meson.yaml
index 4d84978..bf7e8ef 100644
--- a/jenkins/jobs/meson.yaml
+++ b/jenkins/jobs/meson.yaml
@@ -27,6 +27,8 @@
             after: true
           skip-tag: true
           wipe-workspace: false
+          submodule:
+            recursive: true
     triggers:
       - reverse:
           jobs: '{obj:parent_jobs}'
diff --git a/jenkins/jobs/perl-modulebuild.yaml b/jenkins/jobs/perl-modulebuild.yaml
index 7173493..cea0597 100644
--- a/jenkins/jobs/perl-modulebuild.yaml
+++ b/jenkins/jobs/perl-modulebuild.yaml
@@ -27,6 +27,8 @@
             after: true
           skip-tag: true
           wipe-workspace: false
+          submodule:
+            recursive: true
     triggers:
       - reverse:
           jobs: '{obj:parent_jobs}'
diff --git a/jenkins/jobs/python-distutils.yaml b/jenkins/jobs/python-distutils.yaml
index f56794c..4921aa7 100644
--- a/jenkins/jobs/python-distutils.yaml
+++ b/jenkins/jobs/python-distutils.yaml
@@ -27,6 +27,8 @@
             after: true
           skip-tag: true
           wipe-workspace: false
+          submodule:
+            recursive: true
     triggers:
       - reverse:
           jobs: '{obj:parent_jobs}'
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] jenkins: recursively update submodules on checkout

Posted by Andrea Bolognani 2 weeks ago
On Wed, 2020-01-08 at 16:04 +0000, Daniel P. Berrangé wrote:
> The ansible playback runs 'git submodule update --init', so we

s/ansible playback/Ansible playbook/

> should have jenkins do the equivalent to ensure consistent

s/jenkins/Jenkins/
s/ensure/ensure a/

> build environment setup.
> 
> In particular this works arounda bug with Meson when using

s/arounda/around a/

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list