Previous commits to eliminate gnulib modules accidentally
used some glib APIs not available in Debian 9.

GLib has support for compile time version checking of
APIs but we mistakenly havent enabled it in libvirt.

This series fixes the bad API usage, then enables
version checkihng, and finally adds Debian to the
Travis config

Daniel P. Berrangé (7):
  util: always replace g_fsync usage with our wrapper
  util: keep glib compat methods in alphabetical order
  util: fix indent depth for glib compat impls
  util: add compat impl of g_canonicalize_filename
  src: remove use of g_date_time_new_from_iso8601 function
  util: introduce compile time API version checking
  travis: add build for Debian 9

 .travis.yml              |   7 ++
 config-post.h            |  10 ++
 src/conf/domain_conf.c   |  28 ++++--
 src/esx/esx_vi_types.c   |  56 +++++++++--
 src/libvirt_private.syms |   1 +
 src/util/glibcompat.c    | 196 ++++++++++++++++++++++++++++++++++-----
 src/util/glibcompat.h    |  10 +-
 src/vz/vz_sdk.c          |  24 ++++-
 8 files changed, 286 insertions(+), 46 deletions(-)

-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 1/6/20 2:26 PM, Daniel P. Berrangé wrote:
> Previous commits to eliminate gnulib modules accidentally
> used some glib APIs not available in Debian 9.
> 
> GLib has support for compile time version checking of
> APIs but we mistakenly havent enabled it in libvirt.
> 
> This series fixes the bad API usage, then enables
> version checkihng, and finally adds Debian to the
> Travis config
> 
> Daniel P. Berrangé (7):
>    util: always replace g_fsync usage with our wrapper
>    util: keep glib compat methods in alphabetical order
>    util: fix indent depth for glib compat impls
>    util: add compat impl of g_canonicalize_filename
>    src: remove use of g_date_time_new_from_iso8601 function
>    util: introduce compile time API version checking
>    travis: add build for Debian 9


All patches:


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


> 
>   .travis.yml              |   7 ++
>   config-post.h            |  10 ++
>   src/conf/domain_conf.c   |  28 ++++--
>   src/esx/esx_vi_types.c   |  56 +++++++++--
>   src/libvirt_private.syms |   1 +
>   src/util/glibcompat.c    | 196 ++++++++++++++++++++++++++++++++++-----
>   src/util/glibcompat.h    |  10 +-
>   src/vz/vz_sdk.c          |  24 ++++-
>   8 files changed, 286 insertions(+), 46 deletions(-)
> 


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, Jan 06, 2020 at 05:26:48PM +0000, Daniel P. Berrangé wrote:
> Previous commits to eliminate gnulib modules accidentally
> used some glib APIs not available in Debian 9.
> 
> GLib has support for compile time version checking of
> APIs but we mistakenly havent enabled it in libvirt.
> 
> This series fixes the bad API usage, then enables
> version checkihng, and finally adds Debian to the
> Travis config
> 
> Daniel P. Berrangé (7):
>   util: always replace g_fsync usage with our wrapper
>   util: keep glib compat methods in alphabetical order
>   util: fix indent depth for glib compat impls
>   util: add compat impl of g_canonicalize_filename
>   src: remove use of g_date_time_new_from_iso8601 function
>   util: introduce compile time API version checking
>   travis: add build for Debian 9

Looks good, there are only some minor issues pointed out.

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list