fix class type instantiated when listing network ports

[libvirt] [PATCH] fix class type instantiated when listing network ports

Posted by Daniel P. Berrangé 4 years, 3 months ago

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 libvirt-override-virNetwork.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt-override-virNetwork.py b/libvirt-override-virNetwork.py
index 749ee44..4245322 100644
--- a/libvirt-override-virNetwork.py
+++ b/libvirt-override-virNetwork.py
@@ -6,6 +6,6 @@
 
         retlist = list()
         for domptr in ret:
-            retlist.append(virNetwork(self, _obj=domptr))
+            retlist.append(virNetworkPort(self, _obj=domptr))
 
         return retlist
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] fix class type instantiated when listing network ports

Posted by Erik Skultety 4 years, 3 months ago

On Thu, Jan 02, 2020 at 03:47:31PM +0000, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  libvirt-override-virNetwork.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libvirt-override-virNetwork.py b/libvirt-override-virNetwork.py
> index 749ee44..4245322 100644
> --- a/libvirt-override-virNetwork.py
> +++ b/libvirt-override-virNetwork.py
> @@ -6,6 +6,6 @@
>
>          retlist = list()
>          for domptr in ret:
> -            retlist.append(virNetwork(self, _obj=domptr))
> +            retlist.append(virNetworkPort(self, _obj=domptr))

The doc string deserves an update as well.
Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list