[v1] Remove the last "no_memory" label

[libvirt] [PATCH 0/7] Remove the last "no_memory" label

Fabiano Fidêncio posted 7 patches 4 years, 3 months ago

Diff against v2
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200102135758.848454-1-fidencio@redhat.com

There is a newer version of this series

docs/hacking.html.in   |  1 -
src/util/virfirewall.c | 94 +++++++++++++++++++-----------------------
2 files changed, 42 insertions(+), 53 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/7] Remove the last "no_memory" label

Posted by Fabiano Fidêncio 4 years, 3 months ago

This series touches virfirewall.c, the last place where a no_memory
label can be found.

The series:
- Renames no_memory to cleanup;
- Gets rid of ENOMEM error treatment;
- Use g_auto / g_autofree in a few different places;
- Add new macros as ADD_ARG heavily rely on a goto;
- Remove no_memory mention from the hacking guide;

I'm not totally sure whether the new macros addition are worth it.

Fabiano Fidêncio (7):
  util: Rename 'no_memory' label to 'cleanup'
  util: Don't set/check for ENOMEM as a firewall error
  util: Use g_auto/g_autofree in virFirewallAddRuleFullV()
  util: Use g_auto in virFirewallStartTransaction()
  util: Add ADD_ARG_RETURN_ON_ERROR
  util: Add ADD_ARG_RETURN_VALUE_ON_ERROR
  docs: Remove mention to no_memory label

 docs/hacking.html.in   |  1 -
 src/util/virfirewall.c | 94 +++++++++++++++++++-----------------------
 2 files changed, 42 insertions(+), 53 deletions(-)

-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list